From: Cyril Hrubis <chrubis@suse.cz>
To: zhanglianjie <zhanglianjie@uniontech.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 5/5] syscalls/clone07: Convert to new API
Date: Wed, 13 Oct 2021 12:00:11 +0200 [thread overview]
Message-ID: <YWauKx1QIWx5g4yn@yuki> (raw)
In-Reply-To: <2a7ff8ae-49f3-bdd8-c5c2-4e6731922978@uniontech.com>
Hi!
> > I do not get why we need this complicated handler setup.
> >
> > Why can't we just SAFE_WAITPID() for the child, check the status and
> > fail the test if the status is anything else than:
> >
> > WIFEXITED(status) && WEXITSTATUS(status) == 0
> >
> The processing here is to accurately determine whether a segment fault
> signal has occurred in the child process. Of course, can also use the
> method you provide, but you can only judge that the child process exits
> abnormally.
Well I do not think that the SEGFAULT needs to have special treatement
here, as long as the child does anything else than exit with 0 it's a
bug, that's why I think that we should fail the test in all other cases.
I guess that we can add special check for the regression with
WIFSIGNALED() && WTERMSIG() == SIGSEGV and produce slightly different
TFAIL message, but we should really fail all the other cases as well.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-10-13 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 8:52 [LTP] [PATCH v3 1/5] syscalls/clone02: Convert to new API zhanglianjie
2021-09-23 8:52 ` [LTP] [PATCH v3 2/5] syscalls/clone03: " zhanglianjie
2021-09-24 9:19 ` Richard Palethorpe
2021-10-11 15:02 ` Cyril Hrubis
2021-09-23 8:52 ` [LTP] [PATCH v3 3/5] syscalls/clone05: " zhanglianjie
2021-10-11 15:59 ` Cyril Hrubis
2021-09-23 8:52 ` [LTP] [PATCH v3 4/5] syscalls/clone06: " zhanglianjie
2021-10-12 9:21 ` Cyril Hrubis
2021-10-13 2:49 ` zhanglianjie
2021-09-23 8:52 ` [LTP] [PATCH v3 5/5] syscalls/clone07: " zhanglianjie
2021-10-12 9:37 ` Cyril Hrubis
2021-10-13 5:14 ` zhanglianjie
2021-10-13 10:00 ` Cyril Hrubis [this message]
2021-10-11 15:40 ` [LTP] [PATCH v3 1/5] syscalls/clone02: " Cyril Hrubis
2021-10-12 6:39 ` zhanglianjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWauKx1QIWx5g4yn@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=zhanglianjie@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox