From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A71C433EF for ; Fri, 15 Oct 2021 09:57:55 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F40561181 for ; Fri, 15 Oct 2021 09:57:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F40561181 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 4131A3C1778 for ; Fri, 15 Oct 2021 11:57:53 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 5A3D03C110D for ; Fri, 15 Oct 2021 11:57:44 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id B023A1A01950 for ; Fri, 15 Oct 2021 11:57:43 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EED6E21A61; Fri, 15 Oct 2021 09:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634291862; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Npp59JNpJGXO0DbVUU9axYHcIFBIcm92F1IzwDjhBW4=; b=lexudAbWTpvy/fgCDh9xbXjc4qvNZFwtx/Ip3uwQzMJjqq8TTOfPNlC2gQwEo+ucdqltg8 x8luG5ylWrtnDhPr7yjV3l2gIYH/PetREWWXkQFdRoY6Dmm2U9770Dmau/iGOy7Skqmr3H CqfOw7SICwuXVSfIosmA5OfSvP3SUyU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634291862; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Npp59JNpJGXO0DbVUU9axYHcIFBIcm92F1IzwDjhBW4=; b=kdcwQr56VZNBHKJi0n2lNWFWBYKjTkzbkKvk5PbMA5CuCJePit1+I1rgRbpeEB4UWqLUpT edKAOP0/gc2ENhAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BFC6F13BEF; Fri, 15 Oct 2021 09:57:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id I3qaLJZQaWFOQgAAMHmgww (envelope-from ); Fri, 15 Oct 2021 09:57:42 +0000 Date: Fri, 15 Oct 2021 11:57:41 +0200 From: Petr Vorel To: zhanglianjie Message-ID: References: <20211014012533.18205-1-zhanglianjie@uniontech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211014012533.18205-1-zhanglianjie@uniontech.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4 1/5] syscalls/clone02: Convert to new API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi, > +++ b/testcases/kernel/syscalls/clone/clone02.c ... > +static char *res_name[] = { > + [1] = "CLONE_VM", > + [2] = "CLONE_FS", > + [4] = "CLONE_FILES", > + [8] = "CLONE_SIGHAND", > }; Not really that important, but you could 1) Instead of hardwired indexes use constants from . 2) To get their string values with macro stringification. #define CLONE_DESC(x) [x] = #x static char *res_name[] = { CLONE_DESC(CLONE_VM), CLONE_DESC(CLONE_FS), CLONE_DESC(CLONE_FILES), CLONE_DESC(CLONE_SIGHAND), }; If this is the only change, it can be replaced during merge. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp