From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93421C433EF for ; Tue, 26 Oct 2021 07:13:40 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05EF860E75 for ; Tue, 26 Oct 2021 07:13:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 05EF860E75 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id EF6C73C677D for ; Tue, 26 Oct 2021 09:13:36 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 633B73C6626 for ; Tue, 26 Oct 2021 09:13:24 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 249702010BD for ; Tue, 26 Oct 2021 09:13:23 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1A25C21940; Tue, 26 Oct 2021 07:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635232403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pdIlvWfJl13O3bJ5qWBAeqJfAIOu/FT+PstP7GOOjkQ=; b=hcyYswUfZ/pUgDFF4Z1fTh9P9JFpY06JtjAPorlbZg81pU1ggQL7cQ6A0kfIGjQdfSEDqN iHXxqTuzdFH7qmZuiYtolIHsyIug9NK0tqFRhvjhNmdtHfTt53YwZiCq+fTvacLJOl4tIQ mNLjUyfOGwY+3EMjc7qkIk3TEczAijA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635232403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pdIlvWfJl13O3bJ5qWBAeqJfAIOu/FT+PstP7GOOjkQ=; b=n44gwElQAJ+9GNDBJeUoprgvExSj6FRTQVgPcPv7ttY4+DMnXDkY5k3tW4MA5zAAEFhLXj jHyxH8fF6FIrc6BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F01DA13CCA; Tue, 26 Oct 2021 07:13:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 16ugOZKqd2F6LwAAMHmgww (envelope-from ); Tue, 26 Oct 2021 07:13:22 +0000 Date: Tue, 26 Oct 2021 09:14:12 +0200 From: Cyril Hrubis To: Li Wang Message-ID: References: <20211025160134.9283-1-chrubis@suse.cz> <20211025160134.9283-7-chrubis@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 6/6] lib: Add tst_set_runtime() & remove tst_set_timeout() X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > Rarely there is a need to set the test runtime dynamically, the only > > tests in LTP that does this are the timer tests that can get two > > parameters, number of iterations and sleep time, and the test runtime is > > close to the multiplication of these two. > > > > It's still cleaner to set the runtime and let the test library figure > > out the timeout in this case. > > > > If so, should we consider to hinden the .timeout in struct tst_test > to prevent users from changing it? If we decide to apply this patchset that would be logical end result. There are only a few .timeout = foo left in the codebase after this patchset that either disable timeout for the few unpredictable cases or shorten it to make the test timeout faster if it gets stuck. We can deal with these by making the .max_runtime accept -1 and by shortening the default timeout considerably. > IIRC, we currently have ".timeout == -1" to disable test timed > out in unsure situation, e.g some OOM tests. But in this patch, > I saw you remove that, but not handle it in tst_set_runtime. Ah, right, I've removed the timeout == -1 handling by mistake. I wanted to keep it working after this patchset as well until a follow up patchset deals with the rest of the tests that set the .timeout. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp