From: Cyril Hrubis <chrubis@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 03/11] syscalls/quotactl04: Remove useless quotactl mount options
Date: Tue, 26 Oct 2021 16:03:13 +0200 [thread overview]
Message-ID: <YXgKoQ72mqFN6uD3@yuki> (raw)
In-Reply-To: <1634562591-5830-3-git-send-email-xuyang2018.jy@fujitsu.com>
Hi!
> When use -O quota options for mkfs.ext4, quota mount option
> will be ignored[1]. So remove it.
>
> Also add docparse formatting.
>
> [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7c319d3
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> testcases/kernel/syscalls/quotactl/quotactl04.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl04.c b/testcases/kernel/syscalls/quotactl/quotactl04.c
> index fd3afc888..ca6a94263 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl04.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl04.c
> @@ -2,22 +2,33 @@
> /*
> * Copyright (c) 2019 FUJITSU LIMITED. All rights reserved.
> * Author: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> + */
> +
> +/*\
> + * [Description]
> *
> * This testcase checks the basic flag of quotactl(2) for project quota on
> * non-XFS filesystems.
> *
> * 1) quotactl(2) succeeds to turn on quota with Q_QUOTAON flag for project.
> + *
> * 2) quotactl(2) succeeds to set disk quota limits with Q_SETQUOTA flag
> * for project.
> + *
> * 3) quotactl(2) succeeds to get disk quota limits with Q_GETQUOTA flag
> * for project.
> + *
> * 4) quotactl(2) succeeds to set information about quotafile with Q_SETINFO
> * flag for project.
> + *
> * 5) quotactl(2) succeeds to get information about quotafile with Q_GETINFO
> * flag for project.
> + *
> * 6) quotactl(2) succeeds to get quota format with Q_GETFMT flag for project.
> + *
> * 7) quotactl(2) succeeds to get disk quota limit greater than or equal to
> * ID with Q_GETNEXTQUOTA flag for project.
> + *
> * 8) quotactl(2) succeeds to turn off quota with Q_QUOTAOFF flag for project.
> *
> * Minimum e2fsprogs version required is 1.43.
Here as well, the list should be changed to render properly in
asciidoc.
> @@ -34,10 +45,6 @@
> #include "tst_safe_stdio.h"
> #include "tst_test.h"
>
> -#ifndef QFMT_VFS_V1
> -# define QFMT_VFS_V1 4
> -#endif
> -
> #define FMTID QFMT_VFS_V1
> #define MNTPOINT "mntpoint"
> static int32_t fmt_id = FMTID;
> @@ -141,7 +148,7 @@ static void setup(void)
> tst_brk(TCONF, "Test needs mkfs.ext4 >= 1.43 for quota,project option, test skipped");
> pclose(f);
> SAFE_MKFS(tst_device->dev, tst_device->fs_type, fs_opts, NULL);
> - do_mount(tst_device->dev, MNTPOINT, tst_device->fs_type, 0, "quota");
> + do_mount(tst_device->dev, MNTPOINT, tst_device->fs_type, 0, NULL);
> }
>
> static void cleanup(void)
> --
> 2.23.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-10-26 14:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 13:09 [LTP] [PATCH v1 01/11] syscalls/quotactl01: Also test with vfsv1 format Yang Xu
2021-10-18 13:09 ` [LTP] [PATCH v1 02/11] syscalls/quotactl06：Also " Yang Xu
2021-10-20 8:51 ` xuyang2018.jy
2021-10-26 13:45 ` [LTP] [PATCH v1 02/11] syscalls/quotactl06???Also " Cyril Hrubis
2021-10-27 2:50 ` xuyang2018.jy
2021-10-18 13:09 ` [LTP] [PATCH v1 03/11] syscalls/quotactl04: Remove useless quotactl mount options Yang Xu
2021-10-26 14:03 ` Cyril Hrubis [this message]
2021-10-27 2:52 ` xuyang2018.jy
2021-10-18 13:09 ` [LTP] [PATCH v1 04/11] syscalls/quotactl[3, 5, 7]: Add docparse formatting Yang Xu
2021-10-26 14:05 ` Cyril Hrubis
2021-10-27 2:54 ` xuyang2018.jy
2021-10-18 13:09 ` [LTP] [PATCH v1 05/11] lapi/syscalls: Add syscall number for quotactl_fd Yang Xu
2021-10-26 14:09 ` Cyril Hrubis
2021-10-26 13:36 ` [LTP] [PATCH v1 01/11] syscalls/quotactl01: Also test with vfsv1 format Cyril Hrubis
2021-10-27 2:46 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXgKoQ72mqFN6uD3@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox