From: Cyril Hrubis <chrubis@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 04/11] syscalls/quotactl[3, 5, 7]: Add docparse formatting
Date: Tue, 26 Oct 2021 16:05:18 +0200 [thread overview]
Message-ID: <YXgLHulsUiCRQmXE@yuki> (raw)
In-Reply-To: <1634562591-5830-4-git-send-email-xuyang2018.jy@fujitsu.com>
Hi!
> -/*
> - * Test Name: quotactl03
> +/*\
> + * [Description]
> *
> - * Description:
> * quotactl(2) with XGETNEXTQUOTA looks for the next active quota for an user
> * equal or higher to a given ID, in this test the ID is specified to a value
> * close to UINT_MAX(max value of unsigned int). When reaching the upper limit
> @@ -16,11 +15,11 @@
> *
> * This kernel bug of xfs has been fixed in:
> *
> - * commit 657bdfb7f5e68ca5e2ed009ab473c429b0d6af85
> - * Author: Eric Sandeen <sandeen@redhat.com>
> - * Date: Tue Jan 17 11:43:38 2017 -0800
> + * commit 657bdfb7f5e68ca5e2ed009ab473c429b0d6af85
> + * Author: Eric Sandeen <sandeen@redhat.com>
> + * Date: Tue Jan 17 11:43:38 2017 -0800
> *
> - * xfs: don't wrap ID in xfs_dq_get_next_id
> + * xfs: don't wrap ID in xfs_dq_get_next_id
The commit hash of this fix should also go into the tags in the tst_test
structure.
> */
>
> #define _GNU_SOURCE
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl05.c b/testcases/kernel/syscalls/quotactl/quotactl05.c
> index e811e47a4..fbc7f5924 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl05.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl05.c
> @@ -2,19 +2,28 @@
> /*
> * Copyright (c) 2019 FUJITSU LIMITED. All rights reserved.
> * Author: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This testcase checks basic flags of quotactl(2) for project on an XFS filesystem:
> *
> - * This testcase checks basic flags of quotactl(2) for project on an XFS file
> - * system:
> * 1) quotactl(2) succeeds to turn off xfs quota and get xfs quota off status
> * for project.
> + *
> * 2) quotactl(2) succeeds to turn on xfs quota and get xfs quota on status
> * for project.
> + *
> * 3) quotactl(2) succeeds to set and use Q_XGETQUOTA to get xfs disk quota
> * limits for project.
> + *
> * 4) quotactl(2) succeeds to set and use Q_XGETNEXTQUOTA to get xfs disk
> * quota limits Cgreater than or equal to ID for project.
> + *
> * 5) quotactl(2) succeeds to turn off xfs quota and get xfs quota off statv
> * for project.
> + *
> * 6) quotactl(2) succeeds to turn on xfs quota and get xfs quota on statv
> * for project.
> */
Here as well, the list should be fixed to render as a list.
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl07.c b/testcases/kernel/syscalls/quotactl/quotactl07.c
> index db477589b..a55416f0e 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl07.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl07.c
> @@ -2,6 +2,10 @@
> /*
> * Copyright (c) 2019 FUJITSU LIMITED. All rights reserved.
> * Author: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> + */
> +
> +/*\
> + * [Description]
> *
> * This is a regresstion test for kernel commit 3dd4d40b4208
> * ("xfs: Sanity check flags of Q_XQUOTARM call").
> --
> 2.23.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-10-26 14:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 13:09 [LTP] [PATCH v1 01/11] syscalls/quotactl01: Also test with vfsv1 format Yang Xu
2021-10-18 13:09 ` [LTP] [PATCH v1 02/11] syscalls/quotactl06：Also " Yang Xu
2021-10-20 8:51 ` xuyang2018.jy
2021-10-26 13:45 ` [LTP] [PATCH v1 02/11] syscalls/quotactl06???Also " Cyril Hrubis
2021-10-27 2:50 ` xuyang2018.jy
2021-10-18 13:09 ` [LTP] [PATCH v1 03/11] syscalls/quotactl04: Remove useless quotactl mount options Yang Xu
2021-10-26 14:03 ` Cyril Hrubis
2021-10-27 2:52 ` xuyang2018.jy
2021-10-18 13:09 ` [LTP] [PATCH v1 04/11] syscalls/quotactl[3, 5, 7]: Add docparse formatting Yang Xu
2021-10-26 14:05 ` Cyril Hrubis [this message]
2021-10-27 2:54 ` xuyang2018.jy
2021-10-18 13:09 ` [LTP] [PATCH v1 05/11] lapi/syscalls: Add syscall number for quotactl_fd Yang Xu
2021-10-26 14:09 ` Cyril Hrubis
2021-10-26 13:36 ` [LTP] [PATCH v1 01/11] syscalls/quotactl01: Also test with vfsv1 format Cyril Hrubis
2021-10-27 2:46 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXgLHulsUiCRQmXE@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox