From: Cyril Hrubis <chrubis@suse.cz>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3 07/12] syscalls/quotactl08: Test quoatctl01 but quota info hidden in filesystem
Date: Thu, 11 Nov 2021 15:30:06 +0100 [thread overview]
Message-ID: <YY0o7jAxgIHvmczq@yuki> (raw)
In-Reply-To: <618CD8F5.4070408@fujitsu.com>
Hi!
> >> + f = SAFE_POPEN("mkfs.ext4 -V 2>&1", "r");
> >> + rc = fscanf(f, "mke2fs %d.%d.%d",&major,&minor,&patch);
> >> + if (rc != 3)
> >> + tst_res(TWARN, "Unable parse version number");
> >> + else if (major * 10000 + minor * 100 + patch< 14300)
> >> + tst_brk(TCONF, "Test needs mkfs.ext4>= 1.43 for quota option, test skipped");
> >> + pclose(f);
> >
> > Ideally this should be added to the .needs_cmds instead so that we get
> > the minimal version in the test metadata too.
> Good suggestion, I am looking your code. But As my commit log said, add
> a lib mkfs.ext4 version check after this quotactl patchset are merged.
Sure I will continue with the review of the patches next week.
> Then we can add this version check and make use it for not only
> quotactl04,08,09 case but also for statx05.c.
Indeed, the plan is to use this for all tests that needs to check any
versions of the tools.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-11 14:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 10:54 [LTP] [PATCH v3 06/12] lapi/quotactl.h: Add fallback for quotactl_fd Yang Xu
2021-11-09 10:54 ` [LTP] [PATCH v3 07/12] syscalls/quotactl08: Test quoatctl01 but quota info hidden in filesystem Yang Xu
2021-11-10 16:32 ` Cyril Hrubis
2021-11-11 8:48 ` xuyang2018.jy
2021-11-11 14:30 ` Cyril Hrubis [this message]
2021-11-26 9:32 ` xuyang2018.jy
2021-12-13 7:26 ` [LTP] [PATCH v4 1/6] " Yang Xu
2021-12-13 7:26 ` [LTP] [PATCH v4 2/6] syscalls/quotactl02, 5: Add quotactl_fd test variant Yang Xu
2022-01-07 14:30 ` Cyril Hrubis
2021-12-13 7:26 ` [LTP] [PATCH v4 3/6] syscalls/quotactl03: " Yang Xu
2022-01-07 14:59 ` Cyril Hrubis
2021-12-13 7:26 ` [LTP] [PATCH v4 4/6] syscalls/quotactl04: " Yang Xu
2022-01-07 15:35 ` Cyril Hrubis
2022-01-10 10:09 ` xuyang2018.jy
2021-12-13 7:26 ` [LTP] [PATCH v4 5/6] syscalls/quotactl09: Test error when quota info hidden in filesystem Yang Xu
2022-01-07 15:50 ` Cyril Hrubis
2022-01-10 6:48 ` xuyang2018.jy
2022-01-10 14:46 ` Cyril Hrubis
2022-01-11 6:51 ` xuyang2018.jy
2022-01-11 10:55 ` Cyril Hrubis
2022-01-12 1:52 ` xuyang2018.jy
2022-01-12 8:31 ` Cyril Hrubis
2022-01-12 9:24 ` xuyang2018.jy
2021-12-13 7:26 ` [LTP] [PATCH v4 6/6] syscalls/quotactl07: Add quotactl_fd test variant Yang Xu
2022-01-07 16:03 ` Cyril Hrubis
2022-01-10 9:03 ` xuyang2018.jy
2021-12-23 8:03 ` [LTP] [PATCH v4 1/6] syscalls/quotactl08: Test quoatctl01 but quota info hidden in filesystem xuyang2018.jy
2022-01-07 14:09 ` Cyril Hrubis
2022-01-10 6:37 ` xuyang2018.jy
2022-01-10 14:46 ` Cyril Hrubis
2021-11-09 10:54 ` [LTP] [PATCH v3 08/12] syscalls/quotactl02, 5: Add quotactl_fd test variant Yang Xu
2021-11-09 10:54 ` [LTP] [PATCH v3 09/12] syscalls/quotactl03: " Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY0o7jAxgIHvmczq@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox