From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4111BC433F5 for ; Wed, 3 Nov 2021 13:15:33 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97D0F61076 for ; Wed, 3 Nov 2021 13:15:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 97D0F61076 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 09E573C71CE for ; Wed, 3 Nov 2021 14:15:31 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 0D4C83C129E for ; Wed, 3 Nov 2021 14:15:21 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 253541A00A5E for ; Wed, 3 Nov 2021 14:15:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 72776218F0; Wed, 3 Nov 2021 13:15:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635945319; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+xdPiHnxc1q0ClFTcIgcC6oU3ydUpjONcN4Eob6uCs=; b=kbXIW9+d928xCKbUUS4I5Udt/BwTPmsappf9eqFQROwDn5qcW0NoM514nO18lTN9km+LbP 1FwD1hsSHbsFMGx8Aoy9zzsOnsXr2FyvXLE3CsKp1cooJVt3UK7BggOGUfW2mneR6Es5WC 0PUHZtPfAb/PhJicNqz6Hu3uPTUQloA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635945319; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+xdPiHnxc1q0ClFTcIgcC6oU3ydUpjONcN4Eob6uCs=; b=HrRKqbZlC6mMniuSQAK0a71mt8SqiHVIAqKqgbRkeZ5nh1+WvdlAxHztd7SI2Yk+LTkUtO 3gCtfbsfQ4KF/vBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5841B13AA2; Wed, 3 Nov 2021 13:15:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3336FGeLgmEYbQAAMHmgww (envelope-from ); Wed, 03 Nov 2021 13:15:19 +0000 Date: Wed, 3 Nov 2021 14:16:15 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20211103120233.20728-1-chrubis@suse.cz> <20211103120233.20728-8-chrubis@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 7/7] docparse: Split into metadata and docparse X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > make install has wrong path (it's on jobs with out-of-tree build and with > Fedora; it's visible in .github/workflows/ci.yml - MAKE_INSTALL but unfortunately GitHub Actions hide these variables): > > https://github.com/pevik/ltp/runs/4092384478?check_suite_focus=true > install -m 00775 "/__w/ltp/ltp-build/metadata/ltp.json" /github/home/ltp-install/opt/ltp/metadata/ltp.json > install -m 00775 "/__w/ltp/ltp-build/metadata/docparse" /github/home/ltp-install/opt/ltp/metadata/docparse > install: cannot stat '/__w/ltp/ltp-build/metadata/docparse': No such file or directory > make[1]: *** [/__w/ltp/ltp/include/mk/env_post.mk:85: /github/home/ltp-install/opt/ltp/metadata/docparse] Error 1 > > Obviously path should be '/__w/ltp/ltp-build/metadata/../docparse' > > Reproducing locally: > $ ./configure CC=clang > $ cd metadata > $ make > $ make install > mkdir -p "/opt/ltp/metadata" > install -m 00775 "ltp.git/metadata/ltp.json" /opt/ltp/metadata/ltp.json > install -m 00775 "ltp.git/metadata/docparse" /opt/ltp/metadata/docparse > install: cannot stat 'ltp.git/metadata/docparse': No such file or directory > make: *** [../include/mk/env_post.mk:85: /opt/ltp/metadata/docparse] Error 1 Actually it's the MAKE_TARGETS := ltp.json docparse which treats the docparse as a actuall file. So I guess that we need this: diff --git a/metadata/Makefile b/metadata/Makefile index 6c36cd210..522af4270 100644 --- a/metadata/Makefile +++ b/metadata/Makefile @@ -6,7 +6,7 @@ top_srcdir ?= .. include $(top_srcdir)/include/mk/env_pre.mk include $(top_srcdir)/include/mk/functions.mk -MAKE_TARGETS := ltp.json docparse +MAKE_TARGETS := ltp.json HOST_MAKE_TARGETS := metaparse INSTALL_DIR = metadata @@ -14,13 +14,16 @@ INSTALL_DIR = metadata ltp.json: metaparse $(abs_srcdir)/parse.sh > ltp.json - -docparse: ltp.json ifeq ($(WITH_METADATA),yes) mkdir -p $(abs_top_builddir)/docparse $(MAKE) -C $(abs_top_builddir)/docparse/ -f $(abs_top_srcdir)/docparse/Makefile endif +ifeq ($(WITH_METADATA),yes) +install: + $(MAKE) -C $(abs_top_builddir)/docparse/ -f $(abs_top_srcdir)/docparse/Makefile install +endif + test: $(MAKE) -C $(abs_srcdir)/tests/ test -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp