public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 7/7] docparse: Split into metadata and docparse
Date: Wed, 3 Nov 2021 14:18:26 +0100	[thread overview]
Message-ID: <YYKMIuHDheI1PK8x@yuki> (raw)
In-Reply-To: <YYKLnxZL44ftguOx@yuki>

Hi!
> Actually it's the
> 
> MAKE_TARGETS := ltp.json docparse
> 
> which treats the docparse as a actuall file.
> 
> So I guess that we need this:
> 
> diff --git a/metadata/Makefile b/metadata/Makefile
> index 6c36cd210..522af4270 100644
> --- a/metadata/Makefile
> +++ b/metadata/Makefile
> @@ -6,7 +6,7 @@ top_srcdir              ?= ..
>  include $(top_srcdir)/include/mk/env_pre.mk
>  include $(top_srcdir)/include/mk/functions.mk
> 
> -MAKE_TARGETS           := ltp.json docparse
> +MAKE_TARGETS           := ltp.json
>  HOST_MAKE_TARGETS      := metaparse
>  INSTALL_DIR            = metadata
> 
> @@ -14,13 +14,16 @@ INSTALL_DIR         = metadata
> 
>  ltp.json: metaparse
>         $(abs_srcdir)/parse.sh > ltp.json
> -
> -docparse: ltp.json
>  ifeq ($(WITH_METADATA),yes)
>         mkdir -p $(abs_top_builddir)/docparse
>         $(MAKE) -C $(abs_top_builddir)/docparse/ -f $(abs_top_srcdir)/docparse/Makefile
>  endif

And obviously if we do not want to install the html pages we can remove
this part:

> +ifeq ($(WITH_METADATA),yes)
> +install:
> +       $(MAKE) -C $(abs_top_builddir)/docparse/ -f $(abs_top_srcdir)/docparse/Makefile install
> +endif

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-11-03 13:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 12:02 [LTP] [PATCH v3 0/7] docparse improvements Cyril Hrubis
2021-11-03 12:02 ` [LTP] [PATCH v3 1/7] docparse: Implement #define and #include Cyril Hrubis
2021-11-03 12:39   ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 2/7] docparse: Add tests Cyril Hrubis
2021-11-04 16:06   ` Petr Vorel
2021-11-05 10:40     ` Cyril Hrubis
2021-11-03 12:02 ` [LTP] [PATCH v3 3/7] docparse: data_storage: Add integer type node Cyril Hrubis
2021-11-04 16:19   ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 4/7] docparse: Implement ARRAY_SIZE() Cyril Hrubis
2021-11-04 20:23   ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 5/7] docparse: Add type normalization Cyril Hrubis
2021-11-04 20:46   ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 6/7] docparse: Group data to 'testsuite' and 'defaults' Cyril Hrubis
2021-11-04 20:47   ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 7/7] docparse: Split into metadata and docparse Cyril Hrubis
2021-11-03 13:04   ` Petr Vorel
2021-11-03 13:06     ` Petr Vorel
2021-11-03 13:16     ` Cyril Hrubis
2021-11-03 13:18       ` Cyril Hrubis [this message]
2021-11-03 14:38         ` Petr Vorel
2021-11-03 15:11           ` Petr Vorel
2021-11-03 15:35             ` Cyril Hrubis
2021-11-04 13:10               ` Cyril Hrubis
2021-11-04 19:40                 ` Petr Vorel
2021-11-05 10:19                   ` Cyril Hrubis
2021-11-05 11:09                     ` Petr Vorel
2021-11-03 15:30           ` Cyril Hrubis
2021-11-04 20:48 ` [LTP] [PATCH v3 0/7] docparse improvements Petr Vorel
2021-11-05 10:43   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYKMIuHDheI1PK8x@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox