From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68630C433EF for ; Wed, 3 Nov 2021 15:37:35 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9690960F9D for ; Wed, 3 Nov 2021 15:37:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9690960F9D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id CF7223C71DA for ; Wed, 3 Nov 2021 16:37:32 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 8E20A3C712D for ; Wed, 3 Nov 2021 16:37:24 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 09BF01A00209 for ; Wed, 3 Nov 2021 16:37:23 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 55AA31FC9E; Wed, 3 Nov 2021 15:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635953843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XsVaUV0D4JjWMhiwIXFBx3QDUWsoGW2C48aA4IxmdFw=; b=JG17iXaokxQWw7mA0up8rnirj05CNue2D/dAcKu6TYxgeWjhQMXUAVZVdpkrIHGhLSLxMj hj2DjtzzXI+71zx/Nn3tSZTwuVrhwCSPKwWxvVr/6ItVenVLCrIOctJcuNY5A6v+pzYGRn 2NmIUTrE28eppvMg18c1QHFcRhTqwVE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635953843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XsVaUV0D4JjWMhiwIXFBx3QDUWsoGW2C48aA4IxmdFw=; b=+pblP+Bz5RvofCF1uianVRnT0qmJbsNDKwUovscX1ptPoSRaZFUBfh5rP/G61Lmudhzybc Hu85Z+Wvkie8BPDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 23BAC13C91; Wed, 3 Nov 2021 15:37:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9udjB7OsgmExPQAAMHmgww (envelope-from ); Wed, 03 Nov 2021 15:37:23 +0000 Date: Wed, 3 Nov 2021 16:38:19 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20211027075615.19832-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 1/1] ver_linux: Print filesystems X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > Ah, sorry, I see why I checked it more complicated way: > with simply checking exit code you have output twice: > > df -hT 2>/dev/null || df > Filesystem Type Size Used Avail Use% Mounted on > devtmpfs devtmpfs 16G 8,0K 16G 1% /dev > tmpfs tmpfs 16G 91M 16G 1% /dev/shm > tmpfs tmpfs 6,2G 4,1M 6,2G 1% /run > ... > df: /run/user/1000/doc: Operation not permitted > Filesystem Type Size Used Avail Use% Mounted on > devtmpfs devtmpfs 16G 8,0K 16G 1% /dev > tmpfs tmpfs 16G 91M 16G 1% /dev/shm > tmpfs tmpfs 6,2G 4,1M 6,2G 1% /run > ... > > => which is IMHO nogo. I could redirect to a file and cut it after, but in that > case v2 is IMHO much better. But still we don't need that grep part, right? So it should be something as: if `df -hT 2>/dev/null >/dev/null`; then df -hT else df fi -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp