From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DC2C433F5 for ; Wed, 3 Nov 2021 15:35:07 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3147B60FC2 for ; Wed, 3 Nov 2021 15:35:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3147B60FC2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 75CC83C71CC for ; Wed, 3 Nov 2021 16:35:05 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 7746B3C712D for ; Wed, 3 Nov 2021 16:34:55 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 2B1C21000998 for ; Wed, 3 Nov 2021 16:34:53 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 56CA5218EE; Wed, 3 Nov 2021 15:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635953693; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ug0R4NWaOQ+1gZdENtnCAA9hZH6bA9zbxok5Gsm4DGM=; b=2vH/hWe8JK5uGXM3m0DC4gzmv6Sl2BHcg+EEaPW5DDoiwzog/SRnIiwkzrmwMq8AzMZ4F+ koq3khhwv298lb6cvxy7Im9S+OqFNeguemB6c4QjbGVKPwP8U2Qk/dBzuND1UC28Ly5H2K qb2XLLNOmiZlipokLrbh/Z+WWqMDdL8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635953693; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ug0R4NWaOQ+1gZdENtnCAA9hZH6bA9zbxok5Gsm4DGM=; b=ZT4P9OkJJ2pRZQe0/gY/dXUHCqvyBLFegobGnq1oEwVK3EDmtUnRiFwxwXxcOKmqUyj6fv JXiyERAENkqE+HDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2A08113C91; Wed, 3 Nov 2021 15:34:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hoLxCR2sgmHjOwAAMHmgww (envelope-from ); Wed, 03 Nov 2021 15:34:53 +0000 Date: Wed, 3 Nov 2021 16:35:49 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20211103120233.20728-1-chrubis@suse.cz> <20211103120233.20728-8-chrubis@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 7/7] docparse: Split into metadata and docparse X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > Changes LGTM (works locally, testing it in CI: > > https://github.com/pevik/ltp/actions/runs/1417208983 > Failed :(. > > Reproducible locally: > make -C "metadata" \ > -f "/home/pvorel/install/src/ltp.git/metadata/Makefile" install > make[1]: Entering directory '/home/pvorel/install/src/ltp.git/metadata' > make -C /home/pvorel/install/src/ltp.git/docparse/ -f /home/pvorel/install/src/ltp.git/docparse/Makefile install > make[2]: Entering directory '/home/pvorel/install/src/ltp.git/docparse' > install -m 00775 "/home/pvorel/install/src/ltp.git/docparse/metadata.html" /opt/ltp/metadata/metadata.html > install: cannot stat '/home/pvorel/install/src/ltp.git/docparse/metadata.html': No such file or directory > make[2]: *** [../include/mk/env_post.mk:85: /opt/ltp/metadata/metadata.html] Error 1 > make[2]: Leaving directory '/home/pvorel/install/src/ltp.git/docparse' > make[1]: *** [/home/pvorel/install/src/ltp.git/metadata/Makefile:26: install] Error 2 > make[1]: Leaving directory '/home/pvorel/install/src/ltp.git/metadata' > make: *** [Makefile:138: metadata-install] Error 2 > > Maybe I wrongly applied your patch, could you please have a look? As far as I can tell this just means that the html wasn't build at all, at least that's what was shown by the CI. > Kind regards, > Petr > > diff --git metadata/Makefile metadata/Makefile > index f1d99b243..6c36cd210 100644 > --- metadata/Makefile > +++ metadata/Makefile > @@ -6,7 +6,7 @@ top_srcdir ?= .. > include $(top_srcdir)/include/mk/env_pre.mk > include $(top_srcdir)/include/mk/functions.mk > > -MAKE_TARGETS := ltp.json > +MAKE_TARGETS := ltp.json docparse > HOST_MAKE_TARGETS := metaparse > INSTALL_DIR = metadata I guess that this is the revese diff. > @@ -21,11 +21,6 @@ ifeq ($(WITH_METADATA),yes) > $(MAKE) -C $(abs_top_builddir)/docparse/ -f $(abs_top_srcdir)/docparse/Makefile > endif This part is likely wrong, it should look like: ltp.json: metaparse $(abs_srcdir)/parse.sh > ltp.json ifeq ($(WITH_METADATA),yes) mkdir -p $(abs_top_builddir)/docparse $(MAKE) -C $(abs_top_builddir)/docparse/ -f $(abs_top_srcdir)/docparse/Makefile endif So that in the case that WITH_METADATA is set the rule has three lines not one. And that would explain why the html wasn't build since there was a docparse rule but nothing refrenced it. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp