From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 4/7] docparse: Implement ARRAY_SIZE()
Date: Thu, 4 Nov 2021 21:23:50 +0100 [thread overview]
Message-ID: <YYRBVuS+GunT5j9U@pevik> (raw)
In-Reply-To: <20211103120233.20728-5-chrubis@suse.cz>
Hi Cyril,
> Adds a special handlingn for ARRAY_SIZE() macro.
typo: s/handlingn/handling/
While code LGTM
Not related to this change (it's also in code in current master): return value
of parse_test_struct() is not used.
...
> +static void look_for_array_size(FILE *f, const char *arr_id, struct data_node **res)
> +{
> + const char *token;
> + char buf[2][2048] = {};
> + int cur_buf = 0;
> + int prev_buf = 1;
> +
> + for (;;) {
> + if (!(token = next_token2(f, buf[cur_buf], 2048, NULL)))
nit: there could be sizeof(buf[cur_buf]) instead of hardwiring 2048.
LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-04 20:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 12:02 [LTP] [PATCH v3 0/7] docparse improvements Cyril Hrubis
2021-11-03 12:02 ` [LTP] [PATCH v3 1/7] docparse: Implement #define and #include Cyril Hrubis
2021-11-03 12:39 ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 2/7] docparse: Add tests Cyril Hrubis
2021-11-04 16:06 ` Petr Vorel
2021-11-05 10:40 ` Cyril Hrubis
2021-11-03 12:02 ` [LTP] [PATCH v3 3/7] docparse: data_storage: Add integer type node Cyril Hrubis
2021-11-04 16:19 ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 4/7] docparse: Implement ARRAY_SIZE() Cyril Hrubis
2021-11-04 20:23 ` Petr Vorel [this message]
2021-11-03 12:02 ` [LTP] [PATCH v3 5/7] docparse: Add type normalization Cyril Hrubis
2021-11-04 20:46 ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 6/7] docparse: Group data to 'testsuite' and 'defaults' Cyril Hrubis
2021-11-04 20:47 ` Petr Vorel
2021-11-03 12:02 ` [LTP] [PATCH v3 7/7] docparse: Split into metadata and docparse Cyril Hrubis
2021-11-03 13:04 ` Petr Vorel
2021-11-03 13:06 ` Petr Vorel
2021-11-03 13:16 ` Cyril Hrubis
2021-11-03 13:18 ` Cyril Hrubis
2021-11-03 14:38 ` Petr Vorel
2021-11-03 15:11 ` Petr Vorel
2021-11-03 15:35 ` Cyril Hrubis
2021-11-04 13:10 ` Cyril Hrubis
2021-11-04 19:40 ` Petr Vorel
2021-11-05 10:19 ` Cyril Hrubis
2021-11-05 11:09 ` Petr Vorel
2021-11-03 15:30 ` Cyril Hrubis
2021-11-04 20:48 ` [LTP] [PATCH v3 0/7] docparse improvements Petr Vorel
2021-11-05 10:43 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYRBVuS+GunT5j9U@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox