public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Zhao Gongyi <zhaogongyi@huawei.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] syscalls/epoll_create: add libc test for epoll_create
Date: Fri, 5 Nov 2021 08:56:36 +0100	[thread overview]
Message-ID: <YYTjtMm6mJ6w8Trs@pevik> (raw)
In-Reply-To: <20211105020729.162391-1-zhaogongyi@huawei.com>

Hi Zhao,

> For epoll_create01.c/epoll_create02.c, we add libc epoll_create()
> test because Syscall __NR_epoll_create is not support in some arches.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

FYI in the past I was thinking about further automation of test variant,
thus I added variant_desc (see accept4_01.c). But nowadays most of the test
variants are using struct test_variants (mostly due time64 support thus they use
time64_variants.h). It looks to me only accept4_01.c and epoll_create0[12].c you
just ported, so any optimisation for non-time64 tests is not relevant any more.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-11-05  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05  2:07 [LTP] [PATCH v2] syscalls/epoll_create: add libc test for epoll_create Zhao Gongyi
2021-11-05  7:56 ` Petr Vorel [this message]
2021-11-05 11:54 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYTjtMm6mJ6w8Trs@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=zhaogongyi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox