From: Petr Vorel <pvorel@suse.cz>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: kernel@collabora.com, khazhy@google.com, repnop@google.com,
jack@suse.com, linux-ext4@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 0/9] Test the new fanotify FAN_FS_ERROR event
Date: Fri, 5 Nov 2021 11:10:21 +0100 [thread overview]
Message-ID: <YYUDDU0A9hLFbM4c@pevik> (raw)
In-Reply-To: <20211029211732.386127-1-krisman@collabora.com>
Hi Gabriel, all,
> Hi,
> Now that FAN_FS_ERROR is close to being merged, I'm sending a new
> version of the LTP tests. This is the v3 of this patchset, and it
> applies the feedback of the previous version, in particular, it solves
> the issue Amir pointed out, that ltp won't gracefully handle a test with
> tcnt==0. To solve that, I merged the patch that set up the environment
> with a simple test, that only triggers a fs abort and watches the
> event.
> I'm also renaming the testcase from fanotify20 to fanotify21, to leave
> room for the pidfs test that is also in the baking by Matthew Bobrowski.
> One important detail is that, for the tests to succeed, there is a
> dependency on an ext4 fix I sent a few days ago:
> https://lore.kernel.org/linux-ext4/20211026173302.84000-1-krisman@collabora.com/T/#u
It has been merged into Theodore Ts'o ext4 tree into dev branch as c1e2e0350ce3
("ext4: Fix error code saved on super block during file system abort")
We should probably add it as .tags (see fanotify06.c).
Also it'd be nice just to mention relevant commits which added FAN_FS_ERROR in
fanotify21.c (probably "fanotify: Allow users to request FAN_FS_ERROR events" ?)
+ kernel version it added it -suppose 5.16 (although it can be backported; and
these commits should not go to .tags, as we track there only
fixes not new features). I can add it myself (no need to repost).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-05 10:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 21:17 [LTP] [PATCH v3 0/9] Test the new fanotify FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] [PATCH v3 1/9] syscalls: fanotify: Add macro to require specific mark types Gabriel Krisman Bertazi
2021-11-02 11:27 ` Matthew Bobrowski via ltp
2021-11-02 12:13 ` Amir Goldstein
2021-11-03 16:13 ` Petr Vorel
2021-10-29 21:17 ` [LTP] [PATCH v3 2/9] syscalls: fanotify: Add macro to require specific events Gabriel Krisman Bertazi
2021-10-30 6:11 ` Amir Goldstein
2021-11-02 11:58 ` Matthew Bobrowski via ltp
2021-11-02 12:11 ` Amir Goldstein
2021-10-29 21:17 ` [LTP] [PATCH v3 3/9] syscalls/fanotify21: Introduce FAN_FS_ERROR test Gabriel Krisman Bertazi
2021-10-30 6:15 ` Amir Goldstein
2021-11-05 8:59 ` Petr Vorel
2021-10-29 21:17 ` [LTP] [PATCH v3 4/9] syscalls/fanotify21: Validate the generic error info Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] [PATCH v3 5/9] syscalls/fanotify21: Validate incoming FID in FAN_FS_ERROR Gabriel Krisman Bertazi
2021-11-05 9:49 ` Petr Vorel
2021-10-29 21:17 ` [LTP] [PATCH v3 6/9] syscalls/fanotify21: Support submission of debugfs commands Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] [PATCH v3 7/9] syscalls/fanotify21: Create a corrupted file Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] [PATCH v3 8/9] syscalls/fanotify21: Test file event with broken inode Gabriel Krisman Bertazi
2021-10-29 21:17 ` [LTP] [PATCH v3 9/9] syscalls/fanotify21: Test capture of multiple errors Gabriel Krisman Bertazi
2021-10-30 6:21 ` [LTP] [PATCH v3 0/9] Test the new fanotify FAN_FS_ERROR event Amir Goldstein
2021-11-05 10:10 ` Petr Vorel [this message]
2021-11-05 13:02 ` Amir Goldstein
2021-11-05 13:10 ` Petr Vorel
2021-11-15 21:26 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYUDDU0A9hLFbM4c@pevik \
--to=pvorel@suse.cz \
--cc=jack@suse.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=repnop@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox