From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 3/3] Add test for NFS directory listing regression
Date: Thu, 25 Nov 2021 12:06:15 +0100 [thread overview]
Message-ID: <YZ9uJxpGVuSQGEaA@pevik> (raw)
In-Reply-To: <69812961-2e53-c80d-7b5a-b37305215149@suse.cz>
Hi Martin, Alexey,
> On 24. 11. 21 15:07, Alexey Kodanev wrote:
> > Hi Petr, Martin
> > Overall the new test looks good, and I would only replace the old style
> > command substitution count=`ls ...` with count=$(ls ...).
+1, thanks for a review.
> Good idea.
I'll do that before merging this (later today).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-25 11:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 15:15 [LTP] [PATCH v2 1/3] nfs_lib.sh: Add nfs_get_remote_path() Martin Doucha
2021-11-23 15:15 ` [LTP] [PATCH v2 2/3] nfs_lib.sh: Add support for test-specific parameters Martin Doucha
2021-11-23 19:29 ` Petr Vorel
2021-11-23 15:15 ` [LTP] [PATCH v2 3/3] Add test for NFS directory listing regression Martin Doucha
2021-11-23 19:40 ` Petr Vorel
2021-11-24 9:27 ` Martin Doucha
2021-11-24 9:50 ` Petr Vorel
2021-11-24 10:06 ` Martin Doucha
2021-11-24 10:27 ` Petr Vorel
2021-11-24 14:07 ` Alexey Kodanev
2021-11-24 14:12 ` Martin Doucha
2021-11-25 11:06 ` Petr Vorel [this message]
2021-11-25 13:27 ` Petr Vorel
2021-11-23 19:26 ` [LTP] [PATCH v2 1/3] nfs_lib.sh: Add nfs_get_remote_path() Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ9uJxpGVuSQGEaA@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox