From: Cyril Hrubis <chrubis@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] lib: Add .skip_in_compat flag
Date: Mon, 15 Nov 2021 17:07:50 +0100 [thread overview]
Message-ID: <YZKF1iObIFC8DRGy@yuki> (raw)
In-Reply-To: <20211115152029.22552-2-rpalethorpe@suse.com>
Hi!
> + if (tst_test->skip_in_compat && TST_ABI != tst_kernel_bits())
> + tst_brk(TCONF, "Running in 32-bit compat mode");
^
Not supported
I think that the message as you wrote it may be slightly confusing.
Other than that it looks good:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-15 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 15:20 [LTP] [PATCH 1/2] lib: Cache kernel_bits value Richard Palethorpe via ltp
2021-11-15 15:20 ` [LTP] [PATCH 2/2] lib: Add .skip_in_compat flag Richard Palethorpe via ltp
2021-11-15 16:07 ` Cyril Hrubis [this message]
2021-11-16 8:41 ` Richard Palethorpe
2021-11-15 16:01 ` [LTP] [PATCH 1/2] lib: Cache kernel_bits value Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZKF1iObIFC8DRGy@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox