From: Cyril Hrubis <chrubis@suse.cz>
To: Dai Shili <daisl.fnst@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] syscalls/pread02: Convert to new API and merge pread03 into pread02
Date: Thu, 18 Nov 2021 14:12:58 +0100 [thread overview]
Message-ID: <YZZRWphYxNe07DPs@yuki> (raw)
In-Reply-To: <1636361519-1708-1-git-send-email-daisl.fnst@fujitsu.com>
Hi!
Merged with a minor update to the message below, thanks.
> + TST_EXP_FAIL2(pread(*tc->fd, &buf, tc->nb, tc->offst), tc->exp_errno,
> + "pread(%d, %zu, %ld, %s, %d)", *tc->fd, tc->nb, tc->offst, tc->desc, tc->exp_errno);
The description message is not passed to the call as a parameter and
there is no point to print the expected errno, the TST_EXP_FAIL2() macro
will do that for you. So the format string and parameters were changed
accordingly.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2021-11-18 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 8:29 [LTP] [PATCH] syscalls/pread02: Convert to new API and merge pread03 into pread02 Dai Shili
2021-11-02 16:30 ` Cyril Hrubis
2021-11-08 8:51 ` [LTP] [PATCH v2] " Dai Shili
2021-11-18 13:12 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZZRWphYxNe07DPs@yuki \
--to=chrubis@suse.cz \
--cc=daisl.fnst@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox