public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: tangmeng <tangmeng@uniontech.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] getuid/getuid03: Convert to new API
Date: Thu, 18 Nov 2021 15:49:05 +0100	[thread overview]
Message-ID: <YZZn4WWZLf052bIF@yuki> (raw)
In-Reply-To: <20211116024706.30853-2-tangmeng@uniontech.com>

Hi!
Pushed with several fixes, thanks.

- Rewrote the PASS/FAIL messages to be shorter and more to the point

- Added if (!TST_PASS) return; to the verify() fucntion, since if the
  call has failed there is no point in checking the value againts
  the /proc/self/stat

- There were wrong whitespaces that would have been caught by
  'make check' please make sure to run it before sending patches

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2021-11-18 14:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16  2:47 [LTP] [PATCH v2 1/2] getuid/getuid01: Convert to new API tangmeng
2021-11-16  2:47 ` [LTP] [PATCH v2 2/2] getuid/getuid03: " tangmeng
2021-11-18 14:49   ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZZn4WWZLf052bIF@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=tangmeng@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox