From: Cyril Hrubis <chrubis@suse.cz>
To: Joerg Vehlow <lkml@jv-coder.de>
Cc: Joerg Vehlow <joerg.vehlow@aox-tech.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/4] posix/conformance/interfaces/fork/7-1: Fix test
Date: Mon, 22 Nov 2021 10:41:25 +0100 [thread overview]
Message-ID: <YZtlxQZn06aplsvw@yuki> (raw)
In-Reply-To: <20211122072601.4096577-1-lkml@jv-coder.de>
Hi!
> -static void read_catalog(nl_catd cat, char *who)
> +static int read_catalog(nl_catd cat)
> {
> + static const char *notfound = "not found";
Why static here?
> char *msg = NULL;
> int i, j;
>
> -#if VERBOSE > 0
> - output("Reading the message catalog from %s...\n", who);
> -#endif
> -
> - errno = 0;
> -
> - for (i = 1; i <= 2; i++) {
> + for (i = 1; i <= 3; i++) {
Actually this change makes the test fail for me since there is no set 3.
Have you modified this to check if the test fails and then forget to
change it back?
Other than these two the changes looks good to me. If you agreen I can
fix the two small issues before pushing it to the repo.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-22 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 7:25 [LTP] [PATCH 1/4] posix/conformance/interfaces/fork/7-1: Fix test Joerg Vehlow
2021-11-22 7:25 ` [LTP] [PATCH 2/4] posix/conformance/interfaces: Fix all unused variable warnings Joerg Vehlow
2021-11-22 7:26 ` [LTP] [PATCH 3/4] posix/conformance/interfaces: Fix unused result for write Joerg Vehlow
2021-11-22 7:26 ` [LTP] [PATCH 4/4] posix/interface/conformance: Fix all unused-result warnings Joerg Vehlow
2021-11-22 9:41 ` Cyril Hrubis [this message]
2021-11-22 9:50 ` [LTP] [PATCH 1/4] posix/conformance/interfaces/fork/7-1: Fix test Joerg Vehlow
2021-11-22 10:32 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZtlxQZn06aplsvw@yuki \
--to=chrubis@suse.cz \
--cc=joerg.vehlow@aox-tech.de \
--cc=lkml@jv-coder.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox