From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>, Joerg Vehlow <lkml@jv-coder.de>,
Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: [LTP] [RFC] Using shellcheck for shell make check
Date: Mon, 29 Nov 2021 12:05:59 +0100 [thread overview]
Message-ID: <YaS0F9/ZyPtZi5zE@pevik> (raw)
Hi,
checkbashisms does not detect all things: e.g. not catching {1..$FILE_COUNT}
[1]. Maybe we should reconsider using *also* shellcheck as Joerg suggested
(keep checkbashisms).
I don't like shellcheck output, but it can detects errors checkbashisms cannot
detect (checkbashisms is regexp based, but shellcheck IMHO evaluates the code).
Also it's configurable, thus ve could disable check we don't like or enable only
what we want to check. Or we can run just --severity=warning or
--severity=error. If you're not against it, I can have look into this.
Kind regards,
Petr
[1] https://lore.kernel.org/ltp/YZy5HNteJmoicTtJ@pevik/
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2021-11-29 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 11:05 Petr Vorel [this message]
2021-11-29 11:54 ` [LTP] [RFC] Using shellcheck for shell make check Cyril Hrubis
2021-11-30 9:29 ` Richard Palethorpe
2021-11-30 10:01 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaS0F9/ZyPtZi5zE@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=lkml@jv-coder.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox