From: Cyril Hrubis <chrubis@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] open_posix_testsuite/lio_listio/2-1: increase number of requests
Date: Mon, 29 Nov 2021 15:23:00 +0100 [thread overview]
Message-ID: <YaTiRIANkIEdZ6zL@yuki> (raw)
In-Reply-To: <YaTghxZ06GNiNaY1@yuki>
Hi!
> > static volatile int received_selected;
> > @@ -98,7 +98,7 @@ int main(void)
> > memset(aiocbs[i], 0, sizeof(struct aiocb));
> >
> > aiocbs[i]->aio_fildes = fd;
> > - aiocbs[i]->aio_offset = 0;
> > + aiocbs[i]->aio_offset = i * BUF_SIZE;
>
> The only concern I have is that if the filesystem does not support
> sparse files this will eat up 256MB right?
Ah, it's the same file, that means that it will be just 256kB, that is
fine. Well it would be better to unlink() the file at the end of the
test, but regardless:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-29 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 13:32 [LTP] [PATCH] open_posix_testsuite/lio_listio/2-1: increase number of requests Jan Stancek
2021-11-29 14:15 ` Cyril Hrubis
2021-11-29 14:23 ` Cyril Hrubis [this message]
2021-11-29 14:23 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaTiRIANkIEdZ6zL@yuki \
--to=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox