From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed
Date: Thu, 9 Dec 2021 22:11:04 +0100 [thread overview]
Message-ID: <YbJw6IfUFhVDgQLS@pevik> (raw)
In-Reply-To: <YbIeFLfVb36DaVq8@yuki>
Hi Xu, Cyril,
> Hi!
> > tst_set_timeout $((dev_num*450))
> > + rmmod zram > /dev/null 2>&1 || tst_brk TCONF "zram module is being used"
This is wrong:
$ lsmod | grep zram
# rmmod zram; echo $?
rmmod: ERROR: Module zram is not currently loaded
1
Why not detect with lsmod? i.e.:
if lsmod | grep zram; then
rmmod zram > /dev/null 2>&1 || tst_brk TCONF "zram module is being used"
fi
Although I'm not sure if we should attempt to rmmod, maybe quit when lsmod
detects zram would be better.
Also it wouldn't harm to add at least rmmod into TST_NEEDS_CMDS (in the
zram_lib.sh + take into account TST_NEEDS_CMDS from tests), but that's another
story.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-09 21:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 7:43 [LTP] [PATCH 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-09 7:43 ` [LTP] [PATCH 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-09 15:17 ` Cyril Hrubis
2021-12-09 21:11 ` Petr Vorel [this message]
2021-12-10 8:56 ` xuyang2018.jy
2021-12-10 9:03 ` Petr Vorel
2021-12-10 9:31 ` xuyang2018.jy
2021-12-13 7:40 ` Petr Vorel
2021-12-13 8:05 ` xuyang2018.jy
2021-12-13 10:34 ` Petr Vorel
2021-12-14 3:45 ` xuyang2018.jy
2021-12-14 6:35 ` xuyang2018.jy
2021-12-15 11:56 ` Petr Vorel
2021-12-10 8:27 ` xuyang2018.jy
2021-12-09 7:43 ` [LTP] [PATCH 3/3] zram/zram03: Convert into new api Yang Xu
2021-12-09 21:38 ` Petr Vorel
2021-12-10 10:55 ` xuyang2018.jy
2021-12-10 11:06 ` xuyang2018.jy
2021-12-13 7:30 ` Petr Vorel
2021-12-10 11:40 ` [LTP] [PATCH v2 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-10 11:40 ` [LTP] [PATCH v2 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-10 12:25 ` Cyril Hrubis
2021-12-10 11:40 ` [LTP] [PATCH v2 3/3] zram/zram03: Convert into new api Yang Xu
2021-12-10 12:28 ` Cyril Hrubis
2021-12-13 5:44 ` [LTP] [PATCH v3 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-13 5:44 ` [LTP] [PATCH v3 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-15 6:24 ` xuyang2018.jy
2021-12-10 11:51 ` [LTP] [PATCH v2 1/3] swapping01: skip test if zram-swap is being used Cyril Hrubis
2021-12-10 11:52 ` Cyril Hrubis
2021-12-09 15:15 ` [LTP] [PATCH " Cyril Hrubis
2021-12-09 20:57 ` Petr Vorel
2021-12-10 2:57 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbJw6IfUFhVDgQLS@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox