From: Cyril Hrubis <chrubis@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/3] swapping01: skip test if zram-swap is being used
Date: Fri, 10 Dec 2021 12:52:19 +0100 [thread overview]
Message-ID: <YbM/c45u4KOHN9+h@yuki> (raw)
In-Reply-To: <1639136448-2148-1-git-send-email-xuyang2018.jy@fujitsu.com>
Hi!
> diff --git a/testcases/kernel/mem/swapping/swapping01.c b/testcases/kernel/mem/swapping/swapping01.c
> index 392b79d65..aef47e9a4 100644
> --- a/testcases/kernel/mem/swapping/swapping01.c
> +++ b/testcases/kernel/mem/swapping/swapping01.c
> @@ -40,10 +40,10 @@
>
> #include <sys/types.h>
> #include <sys/wait.h>
> -#include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> #include <unistd.h>
> +#include "tst_safe_stdio.h"
> #include "lapi/abisize.h"
> #include "mem.h"
>
> @@ -67,6 +67,14 @@ static void test_swapping(void)
> #ifdef TST_ABI32
> tst_brk(TCONF, "test is not designed for 32-bit system.");
> #endif
> + FILE *file;
> + char line[PATH_MAX];
> +
> + file = SAFE_FOPEN("/proc/swaps", "r");
> + while (fgets(line, sizeof(line), file)) {
> + if (strstr(line, "/dev/zram"))
> + tst_brk(TCONF, "zram-swap is being used!");
> + }
Actually please add SAFE_FCLOSE(file) here, but otherwise Reviewed...
> init_meminfo();
>
> --
> 2.23.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-10 11:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 7:43 [LTP] [PATCH 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-09 7:43 ` [LTP] [PATCH 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-09 15:17 ` Cyril Hrubis
2021-12-09 21:11 ` Petr Vorel
2021-12-10 8:56 ` xuyang2018.jy
2021-12-10 9:03 ` Petr Vorel
2021-12-10 9:31 ` xuyang2018.jy
2021-12-13 7:40 ` Petr Vorel
2021-12-13 8:05 ` xuyang2018.jy
2021-12-13 10:34 ` Petr Vorel
2021-12-14 3:45 ` xuyang2018.jy
2021-12-14 6:35 ` xuyang2018.jy
2021-12-15 11:56 ` Petr Vorel
2021-12-10 8:27 ` xuyang2018.jy
2021-12-09 7:43 ` [LTP] [PATCH 3/3] zram/zram03: Convert into new api Yang Xu
2021-12-09 21:38 ` Petr Vorel
2021-12-10 10:55 ` xuyang2018.jy
2021-12-10 11:06 ` xuyang2018.jy
2021-12-13 7:30 ` Petr Vorel
2021-12-10 11:40 ` [LTP] [PATCH v2 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-10 11:40 ` [LTP] [PATCH v2 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-10 12:25 ` Cyril Hrubis
2021-12-10 11:40 ` [LTP] [PATCH v2 3/3] zram/zram03: Convert into new api Yang Xu
2021-12-10 12:28 ` Cyril Hrubis
2021-12-13 5:44 ` [LTP] [PATCH v3 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-13 5:44 ` [LTP] [PATCH v3 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-15 6:24 ` xuyang2018.jy
2021-12-10 11:51 ` [LTP] [PATCH v2 1/3] swapping01: skip test if zram-swap is being used Cyril Hrubis
2021-12-10 11:52 ` Cyril Hrubis [this message]
2021-12-09 15:15 ` [LTP] [PATCH " Cyril Hrubis
2021-12-09 20:57 ` Petr Vorel
2021-12-10 2:57 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbM/c45u4KOHN9+h@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox