From: Cyril Hrubis <chrubis@suse.cz>
To: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/4] controllers/memcg: update stress test to work under cgroup2
Date: Fri, 10 Dec 2021 11:45:16 +0100 [thread overview]
Message-ID: <YbMvvIOMQqsMRC3d@yuki> (raw)
In-Reply-To: <YbMurQKsabIfCOMu@yuki>
Hi!
> > Let me know what you think. I wouldn't want to add anything huge to the API
> > without your blessing :)
>
> Wouldn't it be easier to rewrite these test to the C then? I think that
> error handling in shell CGroup tests would always be more difficuilt
> than in C and given that we have a nice library for C it actually sounds
> like a better solution.
Also not to mention other problems, in shell you actually need at least
one fork to do anything which isn't ideal when you are stress testing
memory, which means that the fork() may fail. While in C you just call a
syscall which is less likely to fail or be stalled due to the load...
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-10 10:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 0:04 [LTP] [PATCH 0/4] Update cgroup_fj and memcg controller tests to work under cgroup2 Luke Nowakowski-Krijger
2021-11-27 0:04 ` [LTP] [PATCH 1/4] controllers/memcg: update stress test " Luke Nowakowski-Krijger
2021-12-01 9:13 ` Li Wang
2021-12-01 22:17 ` Luke Nowakowski-Krijger
2021-12-02 7:46 ` Li Wang
2021-12-02 9:23 ` Richard Palethorpe
2021-12-02 19:28 ` Luke Nowakowski-Krijger
2021-12-03 10:25 ` Li Wang
2021-12-03 20:44 ` Luke Nowakowski-Krijger
2021-12-06 8:31 ` Richard Palethorpe
2021-12-09 21:42 ` Luke Nowakowski-Krijger
2021-12-10 10:40 ` Cyril Hrubis
2021-12-10 10:45 ` Cyril Hrubis [this message]
2021-12-13 8:50 ` Richard Palethorpe
2021-11-27 0:04 ` [LTP] [PATCH 2/4] controllers/memcg: Skip functional tests when mounted under cgroup2 hierarchy Luke Nowakowski-Krijger
2021-11-27 0:04 ` [LTP] [PATCH 3/4] controllers/cgroup_fj: Update cgroup_fj_common to work under cgroup2 Luke Nowakowski-Krijger
2021-11-27 0:04 ` [LTP] [PATCH 4/4] controllers/cgroup_fj: Update cgroup_fj_function " Luke Nowakowski-Krijger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbMvvIOMQqsMRC3d@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=luke.nowakowskikrijger@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox