From: Petr Vorel <pvorel@suse.cz>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed
Date: Mon, 13 Dec 2021 08:40:05 +0100 [thread overview]
Message-ID: <Ybb41TwZ1vSiCAzO@pevik> (raw)
In-Reply-To: <61B31EA0.9020104@fujitsu.com>
Hi Xu,
...
> >> ps: zram01 need to rmmod and modprobe zram. So if kernel built with
> >> CONFIG_ZRAM=y, we also need to TCONF. But it is another story.
> > +1
We already have v3, but I got confused here in v1, thus asking.
> Since zram_lib.sh uses tst_needs_driver to search module in
> modules.dep/modules.builtin. Maybe we can introduce a new macro
> TST_NEEDS_MODULES (like TST_NEEDS_DIRVERS)?
I got lost here, did you suggest zram_lib.sh to switch to use $TST_NEEDS_MODULE?
> The difference between TST_NEEDS_MODULES and TST_NEEDS_DIRVERS is that
> the former needs module, but the latter needs module or builtin.
Yes, and TST_NEEDS_DRIVERS is already used in zram_lib.sh.
Kind regards,
Petr
> But I am not sure whether have many shell case needs this(Like network.)
> Of course, kconfig shell api also can do this.
> Ok, I am back to this case and write my v2 patch.
> Best Regards
> Yang Xu
> > Kind regards,
> > Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-13 7:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 7:43 [LTP] [PATCH 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-09 7:43 ` [LTP] [PATCH 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-09 15:17 ` Cyril Hrubis
2021-12-09 21:11 ` Petr Vorel
2021-12-10 8:56 ` xuyang2018.jy
2021-12-10 9:03 ` Petr Vorel
2021-12-10 9:31 ` xuyang2018.jy
2021-12-13 7:40 ` Petr Vorel [this message]
2021-12-13 8:05 ` xuyang2018.jy
2021-12-13 10:34 ` Petr Vorel
2021-12-14 3:45 ` xuyang2018.jy
2021-12-14 6:35 ` xuyang2018.jy
2021-12-15 11:56 ` Petr Vorel
2021-12-10 8:27 ` xuyang2018.jy
2021-12-09 7:43 ` [LTP] [PATCH 3/3] zram/zram03: Convert into new api Yang Xu
2021-12-09 21:38 ` Petr Vorel
2021-12-10 10:55 ` xuyang2018.jy
2021-12-10 11:06 ` xuyang2018.jy
2021-12-13 7:30 ` Petr Vorel
2021-12-10 11:40 ` [LTP] [PATCH v2 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-10 11:40 ` [LTP] [PATCH v2 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-10 12:25 ` Cyril Hrubis
2021-12-10 11:40 ` [LTP] [PATCH v2 3/3] zram/zram03: Convert into new api Yang Xu
2021-12-10 12:28 ` Cyril Hrubis
2021-12-13 5:44 ` [LTP] [PATCH v3 1/3] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-13 5:44 ` [LTP] [PATCH v3 2/3] zram/zram_lib.sh: Skip test if zram module can not be removed Yang Xu
2021-12-15 6:24 ` xuyang2018.jy
2021-12-10 11:51 ` [LTP] [PATCH v2 1/3] swapping01: skip test if zram-swap is being used Cyril Hrubis
2021-12-10 11:52 ` Cyril Hrubis
2021-12-09 15:15 ` [LTP] [PATCH " Cyril Hrubis
2021-12-09 20:57 ` Petr Vorel
2021-12-10 2:57 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybb41TwZ1vSiCAzO@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox