From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [RFC] enable OOM protection for the library and test process?
Date: Mon, 13 Dec 2021 16:08:25 +0100 [thread overview]
Message-ID: <Ybdh6Q8OFheyDBn9@yuki> (raw)
In-Reply-To: <CAEemH2f_bkCkGiAnB3-8G07rYuVb9hZzKAKO3EMXUExDnx1Fdw@mail.gmail.com>
Hi!
> > (if we haven't tried already) Could we make expected victim process
> > more appealing target by tweaking its oom_score/oom_score_adj ?
> >
>
> This might not be a good way.
>
> Because OOM Killer counts the oom_score by itself algorithm for
> choosing which process to kill. If we tweak that, it will interfere with
> the scientificity of the OOM test. But if we only do protect the
> lib-process,
> we know that shouldn't be killed and the test will report correctly for us.
Agree here, we shouldn't really touch the score of the process that is
supposed to be killed unless we want to test different scenarios. It
would make sense to run the test with slightly different score for the
child too, but we shouldn't remove the original score.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-13 15:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 8:03 [LTP] [RFC] enable OOM protection for the library and test process? Li Wang
2021-12-13 9:32 ` Jan Stancek
2021-12-13 10:18 ` Li Wang
2021-12-13 15:08 ` Cyril Hrubis [this message]
2021-12-13 16:06 ` Martin Doucha
2021-12-13 16:15 ` Cyril Hrubis
2021-12-13 16:59 ` Martin Doucha
2021-12-14 6:46 ` Li Wang
2021-12-14 6:31 ` Li Wang
2021-12-16 3:41 ` [LTP] [PATCH 1/3] lib: add functions to adjust oom score Li Wang
2021-12-16 3:41 ` [LTP] [PATCH 2/3] ltp: enable OOM protection for main and test harness process Li Wang
2021-12-16 7:55 ` Petr Vorel
2021-12-16 9:50 ` Martin Doucha
2021-12-17 1:50 ` Li Wang
2021-12-16 3:41 ` [LTP] [PATCH 3/3] oom: enable OOM protection for mem lib process Li Wang
2021-12-16 7:57 ` Petr Vorel
2021-12-16 7:49 ` [LTP] [PATCH 1/3] lib: add functions to adjust oom score Petr Vorel
2021-12-17 2:02 ` Li Wang
2021-12-17 8:25 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybdh6Q8OFheyDBn9@yuki \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox