Re: [LTP] [PATCH v4] Refactoring dio_append.c using LTP API

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

Info for myself: this patch requires "Add io_read_eof in common.h utilities" [1]

I wonder what I'm missing:
./dio_append
tst_test.c:1409: TINFO: Timeout per run is 0h 05m 00s
dio_append.c:69: TINFO: Parent append to file
common.h:45: TBROK: open(dio_append,16449,0666) failed: EINVAL (22)
common.h:98: TINFO: child 10949 reading file
common.h:98: TINFO: child 10953 reading file
common.h:98: TINFO: child 10940 reading file
common.h:98: TINFO: child 10941 reading file
common.h:98: TINFO: child 10944 reading file
common.h:98: TINFO: child 10946 reading file
common.h:98: TINFO: child 10951 reading file
common.h:98: TINFO: child 10942 reading file
common.h:98: TINFO: child 10948 reading file
common.h:98: TINFO: child 10939 reading file
common.h:98: TINFO: child 10943 reading file
common.h:98: TINFO: child 10950 reading file
common.h:98: TINFO: child 10947 reading file
common.h:98: TINFO: child 10945 reading file
common.h:98: TINFO: child 10952 reading file
common.h:98: TINFO: child 10954 reading file

Summary:
passed   0
failed   0
broken   1
skipped  0
warnings 0

> +++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
...
> +static void run(void)
> +{
> +	char *filename = "dio_append";
nit: having the same name as the binary filename is a bit confusing.
(sure will work even run as ./dio_append due use of .needs_tmpdir).

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/20211213121417.21825-1-andrea.cervesato@suse.com/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp