From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D60B3C433EF for ; Tue, 14 Dec 2021 16:39:21 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 741DC3C8D6D for ; Tue, 14 Dec 2021 17:39:19 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 4C2653C8A8C for ; Tue, 14 Dec 2021 17:39:10 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id C3987200972 for ; Tue, 14 Dec 2021 17:39:09 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EB58C21100; Tue, 14 Dec 2021 16:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1639499948; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=guHmbwqflIwEkepaULgZsEuZNfYzCQGk2Bq8FJ6I3lU=; b=z0e0BqANhs44BBo771hJm7HR2GptpmETppWIwE7ekIpPTB0PQXwt22vjbhrsnH9mxHxAWk kMvNRvMRA7EuihnPCChz32TEsdkCo+jK/D+H0EIRVa7YwSbaCUH0ZbAhtA3+R29jXxbHh2 l5N7baTWOYIfOizyxp6govP5lRdK3iQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1639499948; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=guHmbwqflIwEkepaULgZsEuZNfYzCQGk2Bq8FJ6I3lU=; b=YhizRE83IAGpEQDHKxxneVOYaI/gA3ilK0hOQivJ1rNTimAVlkHs0NXj3EiCH5vgy1p9dW oV2ELW2LVnQa2lBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C0E7513CE9; Tue, 14 Dec 2021 16:39:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3X6bLazIuGGOCQAAMHmgww (envelope-from ); Tue, 14 Dec 2021 16:39:08 +0000 Date: Tue, 14 Dec 2021 17:39:07 +0100 From: Petr Vorel To: Cyril Hrubis Message-ID: References: <20211213160437.32353-1-andrea.cervesato@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4] Refactoring dio_append.c using LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > Hi! > > I wonder what I'm missing: > > ./dio_append > > tst_test.c:1409: TINFO: Timeout per run is 0h 05m 00s > > dio_append.c:69: TINFO: Parent append to file > > common.h:45: TBROK: open(dio_append,16449,0666) failed: EINVAL (22) > That's an O_DIRECT open() EINVAL probably means that O_DIRECT is not > supported. Is your /tmp/ on tmpfs? Yes. As we cannot use SAFE_OPEN() in io_read_eof() [1], there should be check for errno I guess. Kind regards, Petr [1] https://lore.kernel.org/ltp/20211213121417.21825-1-andrea.cervesato@suse.com/ -- Mailing list info: https://lists.linux.it/listinfo/ltp