From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Refactoring dio_append.c using LTP API
Date: Wed, 15 Dec 2021 12:35:16 +0100 [thread overview]
Message-ID: <YbnS9OiBV0V0CwuD@yuki> (raw)
In-Reply-To: <YbjIqypOcAYAnLbl@pevik>
Hi!
> > > I wonder what I'm missing:
> > > ./dio_append
> > > tst_test.c:1409: TINFO: Timeout per run is 0h 05m 00s
> > > dio_append.c:69: TINFO: Parent append to file
> > > common.h:45: TBROK: open(dio_append,16449,0666) failed: EINVAL (22)
>
> > That's an O_DIRECT open() EINVAL probably means that O_DIRECT is not
> > supported. Is your /tmp/ on tmpfs?
> Yes. As we cannot use SAFE_OPEN() in io_read_eof() [1], there should be check
> for errno I guess.
Maybe it would be a bit cleaner to add a check that would attempt to
open a dummy file in the test setup and exit the O_DIRECT tests before
they attempt to fork children...
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-15 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 16:04 [LTP] [PATCH v4] Refactoring dio_append.c using LTP API Andrea Cervesato via ltp
2021-12-14 15:04 ` Petr Vorel
2021-12-14 15:13 ` Cyril Hrubis
2021-12-14 16:39 ` Petr Vorel
2021-12-15 11:35 ` Cyril Hrubis [this message]
2021-12-15 11:50 ` Petr Vorel
2021-12-15 13:11 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbnS9OiBV0V0CwuD@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox