From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71B67C433F5 for ; Wed, 15 Dec 2021 11:51:01 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id E7A143C8F38 for ; Wed, 15 Dec 2021 12:50:58 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 091E03C104E for ; Wed, 15 Dec 2021 12:50:49 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 19219201094 for ; Wed, 15 Dec 2021 12:50:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 22C0E210F9; Wed, 15 Dec 2021 11:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1639569048; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1EoIVVgvsJZhc4BRiiuSdkoviF226zqO5/Fn4H0vNf8=; b=JuHWa3x2DsDWJc9mkAqadHUjLBrPN3/reX/Y6g26Y8e/E3hgRoLqrQmpOwZVT8vm1EWRRP 9SPKfyzNTFwDyAftPEX9gljKRlUiOaSSPr6zyBBbqLs0+cUId84mMAfmjV4Yqt4LiBjzKy +1xz7JhRfaMbnTwv4dTJqjFtoyfnZ4Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1639569048; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1EoIVVgvsJZhc4BRiiuSdkoviF226zqO5/Fn4H0vNf8=; b=pDW8SW5kcTTNtJTp3T4MM1VkxknUqm9fwIQU2TQMZxsOxNO7oTsCYyFoHGFg+yBg1RBLJb b2lUuPVfnQT3OABg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EEEBF13B27; Wed, 15 Dec 2021 11:50:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jxKgOJfWuWF0HQAAMHmgww (envelope-from ); Wed, 15 Dec 2021 11:50:47 +0000 Date: Wed, 15 Dec 2021 12:50:46 +0100 From: Petr Vorel To: Cyril Hrubis Message-ID: References: <20211213160437.32353-1-andrea.cervesato@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4] Refactoring dio_append.c using LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi, ... > > > That's an O_DIRECT open() EINVAL probably means that O_DIRECT is not > > > supported. Is your /tmp/ on tmpfs? > > Yes. As we cannot use SAFE_OPEN() in io_read_eof() [1], there should be check > > for errno I guess. > Maybe it would be a bit cleaner to add a check that would attempt to > open a dummy file in the test setup and exit the O_DIRECT tests before > they attempt to fork children... +1 Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp