From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F4F7C433F5 for ; Wed, 15 Dec 2021 13:10:25 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id A51C03C8FD6 for ; Wed, 15 Dec 2021 14:10:22 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 348263C6433 for ; Wed, 15 Dec 2021 14:10:12 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id D0C8F601BC9 for ; Wed, 15 Dec 2021 14:10:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 77561212C7; Wed, 15 Dec 2021 13:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1639573810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nx2Sroj4iDZjup8/aoU83kwzoqEllLj4uc334X7zTPs=; b=mk7S3puYoEtU64inT9tcGESBIo+6Hzs+2SZCKVPA252MqkdL7HNRKj8g/0+e98l63+IZ7U Vv4AX2K/7mQfZvWzsuDImvKsQmqkqJF4eg6IOBGN0Yy3hGBrreSWjTF6nS5C6XSX96VIuv SEPdrrct5pk9YBUis8h9wTdYQckpb8w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1639573810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nx2Sroj4iDZjup8/aoU83kwzoqEllLj4uc334X7zTPs=; b=8Sw8b2jseZEzrN7JjYb80vbJzlbfUoPhfnwgGvFY0vumAaEh/3AIHjErcmj6udwyo02PEE qJTya/JXPPP2NfAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 622FF1330B; Wed, 15 Dec 2021 13:10:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CT18FjLpuWGYQwAAMHmgww (envelope-from ); Wed, 15 Dec 2021 13:10:10 +0000 Date: Wed, 15 Dec 2021 14:11:35 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20211213160437.32353-1-andrea.cervesato@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211213160437.32353-1-andrea.cervesato@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4] Refactoring dio_append.c using LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! Pushed with two minor changes, thanks. > +/*\ > + * [Description] > * > - */ > -/* > * dio_append - append zeroed data to a file using O_DIRECT while > * a 2nd process is doing buffered reads and check if the buffer > * reads always see zero. > */ I did rewrite this description to be a bit better. > +static struct tst_test test = { > + .test_all = run, > + .setup = setup, > + .cleanup = cleanup, > + .needs_tmpdir = 1, > + .forks_child = 1, > + .options = (struct tst_option[]) { > + {"n:", &str_numchildren, "Number of threads (default 1000)"}, > + {"w:", &str_writesize, "Write size for each append (default 64K)"}, > + {"c:", &str_appends, "Number of appends (default 1000)"}, And fixed these descriptions. The description for n: didn't match it at all. For the rest I've added the switch to the string description as well, as currently the test library is dumb and just prints the string as it is. It would be better to fix the library to print the swich automatically and then fix all the tests not to include the switches in the string description. And ideally we would pass a default value in this structure as well... But for now the message should include the switches otherwise it's incomprehensible to the user. > + {} > + }, > +}; -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp