From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3 1/3] lib: add functions to adjust oom score
Date: Tue, 21 Dec 2021 09:33:13 +0100 [thread overview]
Message-ID: <YcGRST7vAycVk0AA@pevik> (raw)
In-Reply-To: <CAEemH2d6PPi94q3PhMyR1Js_Rqr1dpfvch=ex3HpuHfQKJYTnw@mail.gmail.com>
Hi Li,
> > > + if (access("/proc/self/oom_score_adj", F_OK) == -1) {
> > We need to check here also /proc/PID/oom_score_adj, i.e. score_path.
> Good catch, I would add a 'W_OK' checking and skip the setting with
> a reminder message if run without root.
> how about this?
> if (access(score_path, W_OK) == -1) {
> tst_res(TINFO, "Warning: %s cannot be accessed for writing,
> please check if test run with root user.",
> score_path);
> return
> }
No, value < 0 obviously requires root, thus access() check is not enough.
Try echo -1 > /proc/$$/oom_score_adj
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-21 8:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 9:54 [LTP] [PATCH v3 1/3] lib: add functions to adjust oom score Li Wang
2021-12-20 9:54 ` [LTP] [PATCH v3 2/3] lib: enable OOM protection for ltp lib process Li Wang
2021-12-20 13:26 ` Cyril Hrubis
2021-12-20 9:54 ` [LTP] [PATCH v3 3/3] oom: enable OOM protection for mem " Li Wang
2021-12-20 13:27 ` Cyril Hrubis
2021-12-20 13:26 ` [LTP] [PATCH v3 1/3] lib: add functions to adjust oom score Cyril Hrubis
2021-12-20 18:13 ` Petr Vorel
2021-12-20 18:34 ` Petr Vorel
2021-12-21 2:50 ` Li Wang
2021-12-21 8:33 ` Petr Vorel [this message]
2021-12-21 9:18 ` Cyril Hrubis
2021-12-21 9:23 ` Li Wang
2021-12-21 9:40 ` Li Wang
2021-12-21 9:59 ` Cyril Hrubis
2021-12-21 10:12 ` Li Wang
2021-12-21 10:36 ` Cyril Hrubis
2021-12-21 10:44 ` Petr Vorel
2021-12-21 11:32 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcGRST7vAycVk0AA@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox