From: Petr Vorel <pvorel@suse.cz>
To: xuyang2018.jy@fujitsu.com, Li Wang <liwang@redhat.com>
Cc: Richard Palethorpe <rpalethorpe@suse.com>,
"ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/1] lib: Skip tst_{disable, enable}_oom_protection() for non-root
Date: Wed, 22 Dec 2021 09:06:26 +0100 [thread overview]
Message-ID: <YcLcgumNvNoqr2XD@pevik> (raw)
In-Reply-To: <CAEemH2cqTErtNZka8X3L3AgOhy-a2x8fqy1k-QKJWiXc7wA2fA@mail.gmail.com>
Hi Xu, Li, all,
> Hi Xu, Petr,
> On Wed, Dec 22, 2021 at 10:26 AM xuyang2018.jy@fujitsu.com <
> xuyang2018.jy@fujitsu.com> wrote:
> > Hi Petr
> > > If needed to set value also for non-root, use set_oom_score_adj().
> > If so, why not rename set_oom_score_adj to tst_set_oom_score_adj and add
> > declartion to tst_memutils.h?
> Yes, it makes sense to expose this function to users to cover
> more oom test scenarios. For instance, set a high (>0) or low (<0)
> score in child_alloc() to verify if OOM-Killer still works well.
> But so far, we don't have such tests.
Sure, I we can do it. But first I'd prefer to fix CI (beware we have last
working day before xmas vacation).
> > ps: also have a word typo in set_oom_score_adj, adjustement => adjustment.
+1, thanks!
Kind regards,
Petr
> > Best Regards
> > Yang Xu
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2021-12-22 8:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 19:35 [LTP] [PATCH 1/1] lib: Skip tst_{disable, enable}_oom_protection() for non-root Petr Vorel
2021-12-22 2:25 ` xuyang2018.jy
2021-12-22 3:32 ` Li Wang
2021-12-22 6:05 ` xuyang2018.jy
2021-12-22 8:14 ` Petr Vorel
2021-12-22 8:37 ` xuyang2018.jy
2021-12-22 9:48 ` Li Wang
2021-12-22 10:09 ` Cyril Hrubis
2021-12-22 10:24 ` Petr Vorel
2021-12-22 10:40 ` Cyril Hrubis
2021-12-22 10:48 ` Petr Vorel
2021-12-22 11:29 ` Li Wang
2021-12-22 11:32 ` Li Wang
2021-12-22 11:25 ` Li Wang
2021-12-22 10:38 ` Petr Vorel
2021-12-22 8:06 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcLcgumNvNoqr2XD@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox