From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>,
"ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/1] lib: Skip tst_{disable, enable}_oom_protection() for non-root
Date: Wed, 22 Dec 2021 11:48:10 +0100 [thread overview]
Message-ID: <YcMCao3J5PIPaTWe@pevik> (raw)
In-Reply-To: <YcMArVLw7UbLT/wi@yuki>
> Hi!
> > We use just FILE_PRINTF(), but we check the result and TWARN, which causes the
> > failure in CI.
> Which is why I argued that we should add a version that does not print
> anything and just returns if the operation was successful or not. I
> guess it could be called TRY_FILE_PRINTF() or something.
OK, got that.
> > I've sent v2, which checks CAP_SYS_ADMIN and CAP_SYS_RESOURCE,
> > but feel free just to bring simpler solution.
> I still think that the most acurate test would be just writing to the
> file and checking the result.
OK. Anybody taking this (so that not more people working on it)?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-22 10:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 19:35 [LTP] [PATCH 1/1] lib: Skip tst_{disable, enable}_oom_protection() for non-root Petr Vorel
2021-12-22 2:25 ` xuyang2018.jy
2021-12-22 3:32 ` Li Wang
2021-12-22 6:05 ` xuyang2018.jy
2021-12-22 8:14 ` Petr Vorel
2021-12-22 8:37 ` xuyang2018.jy
2021-12-22 9:48 ` Li Wang
2021-12-22 10:09 ` Cyril Hrubis
2021-12-22 10:24 ` Petr Vorel
2021-12-22 10:40 ` Cyril Hrubis
2021-12-22 10:48 ` Petr Vorel [this message]
2021-12-22 11:29 ` Li Wang
2021-12-22 11:32 ` Li Wang
2021-12-22 11:25 ` Li Wang
2021-12-22 10:38 ` Petr Vorel
2021-12-22 8:06 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcMCao3J5PIPaTWe@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox