From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] lib: Do not fail a test if oom score cannot be adjusted.
Date: Wed, 22 Dec 2021 15:03:48 +0100 [thread overview]
Message-ID: <YcMwRIZcQNH94xhe@pevik> (raw)
In-Reply-To: <20211222135234.30025-1-chrubis@suse.cz>
Hi Cyril, all,
> From: Petr Vorel <pvorel@suse.cz>
> Setting value < 0 in /proc/*/oom_score_adj requires CAP_SYS_RESOURCE or
> CAP_SYS_ADMIN. However setting the library process score is a best
> effort operation, so let's skip it silently when the user is not
> privileged to do so.
+1
LGTM, thanks for this version, I'm for merging it.
Also tested locally and on CI, working as expected.
https://github.com/pevik/ltp/runs/4607602484?check_suite_focus=true
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-22 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 13:52 [LTP] [PATCH v2] lib: Do not fail a test if oom score cannot be adjusted Cyril Hrubis
2021-12-22 14:03 ` Petr Vorel [this message]
2021-12-23 1:17 ` xuyang2018.jy
2021-12-23 2:13 ` Li Wang
2021-12-23 2:48 ` [LTP] [PATCH v3] " Li Wang
2021-12-23 3:03 ` xuyang2018.jy
2021-12-23 7:57 ` Petr Vorel
2021-12-23 8:29 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcMwRIZcQNH94xhe@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox