From: Petr Vorel <pvorel@suse.cz>
To: Kushal Chand <kushalchand@zilogic.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] tst_taint: Print readable error message instead of numerical code
Date: Wed, 12 Jan 2022 16:18:50 +0100 [thread overview]
Message-ID: <Yd7xWuhoI+IBUi9l@pevik> (raw)
In-Reply-To: <20220111150028.92961-1-kushalchand@zilogic.com>
Hi Kushal,
> if ((taint & taint_mask) != 0)
> - tst_brk(TBROK, "Kernel is already tainted: %u", taint);
> + tst_brk(TBROK, "Kernel is already tainted: TAINT_D (OOPS)");
Kernel can be tainted before testing with different flags than D.
If you don't like the number, how about create function to map taint flag to
char? i.e. similarly to tst_strerrno()?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-12 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 15:00 [LTP] [PATCH v1] tst_taint: Print readable error message instead of numerical code Kushal Chand
2022-01-12 15:18 ` Petr Vorel [this message]
2022-01-13 4:09 ` Kushal Chand
2022-01-14 12:09 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd7xWuhoI+IBUi9l@pevik \
--to=pvorel@suse.cz \
--cc=kushalchand@zilogic.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox