From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ED7EC433F5 for ; Tue, 4 Jan 2022 10:09:36 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 7FB313C8FF5 for ; Tue, 4 Jan 2022 11:09:34 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 623BD3C302A for ; Tue, 4 Jan 2022 11:09:25 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id D207C140019D for ; Tue, 4 Jan 2022 11:09:24 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A40EC2110B; Tue, 4 Jan 2022 10:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1641290963; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g2TUmXb0D0Pxr2b06AXSjkinPPCUnmcyzxkG/Sgyycw=; b=dlzbvnQix/jiuo7A5g4Z/Y0OTriz5WQ7cx/Ior5kIR5h/+NyhlhM54LJtd2vFpEoRssPmE AtbjKWXCS9nUlrBxyRpRbmaLQVgJ93HRDeZd6Fkn3qxGB6GiHtwrumgA/rYLgQdARPOW9R A7nOwfga6AMipdZ283qnATEWQq1T5HY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1641290963; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g2TUmXb0D0Pxr2b06AXSjkinPPCUnmcyzxkG/Sgyycw=; b=JccBCyawko4M65taAOFsCgEFfT6orZFuypnM1jxbcnFBDRxVbUtf2XIkUN5OmSzJSFLfJK l+QKAnboDHMGv7Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 806B413ADB; Tue, 4 Jan 2022 10:09:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 68RgHdMc1GEkGAAAMHmgww (envelope-from ); Tue, 04 Jan 2022 10:09:23 +0000 Date: Tue, 4 Jan 2022 11:09:21 +0100 From: Petr Vorel To: Andrea Cervesato Message-ID: References: <20220104092049.13033-1-andrea.cervesato@suse.com> <20220104092049.13033-2-andrea.cervesato@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220104092049.13033-2-andrea.cervesato@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 1/2] Refactoring aio-stress.c using LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, > + ret = asprintf(&msg, " %.0f < %d", lat->deviations[i], deviations[i]); > + if (ret < 0) > + tst_brk(TBROK, "asprintf memory allocation error"); > + ptr += sprintf(ptr,"%s", msg); ptr += sprintf(ptr,"%s", msg); make check-aio-stress warns: ERROR: space required after that ',' (ctx:VxV) Otherwise obviously ok, waiting if anybody wants to have a look before I merge it. Reviewed-by: Petr Vorel Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp