From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F256EC433F5 for ; Tue, 4 Jan 2022 11:37:40 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 8ED6C3C9015 for ; Tue, 4 Jan 2022 12:37:38 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D67E63C1482 for ; Tue, 4 Jan 2022 12:37:25 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 046131000230 for ; Tue, 4 Jan 2022 12:37:24 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 24D0A1F397; Tue, 4 Jan 2022 11:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1641296244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YS4Wh/FUIwBdVTHNXB1PUkFFBUALW/KbFwW/o90WutM=; b=1usgxb55r1KgN/StehxkRsahSM+Rf82/9Y7U1UcZXflCtWoccbmKwaPQ74sUYJLH1qWH/1 yff9toI4nS7oDnl69ekko8KwKY5nsTpvSjxhK1LnSfnY8u+zW6fHuSu1RRcUksonXSJn0p aKGdITUvUpQrAGeDLnIi8hJ09JWGXfA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1641296244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YS4Wh/FUIwBdVTHNXB1PUkFFBUALW/KbFwW/o90WutM=; b=XtQyP4F2KL5WuLmUk2ZnCYiTjqof5bkoDqbCulv6CYkJyiH8UP10EWATMPhdvMKph84M+9 6LIg6fDzxiBvBBCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 11EA113AE1; Tue, 4 Jan 2022 11:37:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /rwzA3Qx1GE5PgAAMHmgww (envelope-from ); Tue, 04 Jan 2022 11:37:24 +0000 Date: Tue, 4 Jan 2022 12:38:52 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20220104081836.22827-1-andrea.cervesato@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220104081836.22827-1-andrea.cervesato@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1 00/10] watchqueue testing suite X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > described in https://www.kernel.org/doc/html/latest/watch_queue.html > > Andrea Cervesato (10): > Prepare watchqueue testing suite build > Add wqueue01 new test > Add wqueue02 new test > Add wqueue03 new test > Add wqueue04 new test > Add wqueue05 new test > Add wqueue06 new test > Add wqueue07 new test > Add wqueue08 new test Minus the issues I've pointed out this looks like a good basic tests. What is missing are all the more interesting cases, just by looking at the API these are at least: - check that we can filter out events correctly (both for type and subtype) - test that fills up the queue on purpose, i.e. generates events and does not read back until its full, you should get special event if WATCH_META_LOSS_NOTIFICATION is set -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp