From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28F02C433EF for ; Mon, 10 Jan 2022 14:44:43 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id C7BDF3C93BC for ; Mon, 10 Jan 2022 15:44:40 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 1018F3C051B for ; Mon, 10 Jan 2022 15:44:31 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 982701A01490 for ; Mon, 10 Jan 2022 15:44:30 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B95F31F383; Mon, 10 Jan 2022 14:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1641825869; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rQYAKoHyROzPr1VMnEKzrQ1A6jRm6PZn6adkmV9Ds+M=; b=1CZJEPdDPhW1rHTUs6CdY+dsp655PT9HXhjbkA15CVSQqoqZfVXy6Rh9WEi9QkGJL0JMEj OyJIbPxxHKzc1yvdo0d4e5Y7yenQu9IuFQfzbIrqfhk3BNICygryTh3J+ZVzpBgR3nMSMA T0x36dxRi5eD1DgcT2SkAEsxXpNg55A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1641825869; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rQYAKoHyROzPr1VMnEKzrQ1A6jRm6PZn6adkmV9Ds+M=; b=GBTYzduWJuysUN2T/PRDrUBlPxcsvtM8uV1j+TEtTIm7S3ovtXZcnGhpqWz0D2qrboj6Ku CMBlGALHXy+Zz5Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 97B2413D9D; Mon, 10 Jan 2022 14:44:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0SRMIk1G3GHXYwAAMHmgww (envelope-from ); Mon, 10 Jan 2022 14:44:29 +0000 Date: Mon, 10 Jan 2022 15:46:04 +0100 From: Cyril Hrubis To: "xuyang2018.jy@fujitsu.com" Message-ID: References: <1639380414-24390-1-git-send-email-xuyang2018.jy@fujitsu.com> <1639380414-24390-5-git-send-email-xuyang2018.jy@fujitsu.com> <61DBD6D0.1000104@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <61DBD6D0.1000104@fujitsu.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4 5/6] syscalls/quotactl09: Test error when quota info hidden in filesystem X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ltp@lists.linux.it" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > >> + if (tc->exp_err == ENOTBLK) > >> + TEST(do_quotactl(fd, tc->cmd, "/dev/null", *tc->id, tc->addr)); > >> + else > >> + TEST(do_quotactl(fd, tc->cmd, tst_device->dev, *tc->id, tc->addr)); > > > > How does this work for the tst_variant == 1? We still do pass the fd > > pointing to device right? > Yes, but for tst_variant ==1 ,we don't use dev. Well yes, but the fd points to the device, right? So we pass a fd that points to a device and we expect ENOTBLK if tst_variant == 1 and exp_err == ENOTBLK? That does not sound fine, what do I miss? -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp