From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] chdir01.c: Fix on enabled FIPS
Date: Mon, 10 Jan 2022 18:27:16 +0100 [thread overview]
Message-ID: <YdxsdDctFxoWI4E5@pevik> (raw)
In-Reply-To: <YdxOS6zEp3KwY63X@yuki>
Hi Cyril,
> Hi!
> > which causes 0 permission for user and group.
> This could be a bit more verbose.
I'll put more info.
...
> > - if (tc->nobody_err == EACCES && skip_blocked) {
> > + /* FIPS mode disables umask efect for group or other */
> > + if (!(blocked_perm & S_IRGRP) && strcmp(tc->name, "/") != 0) {
> So on FIPS the directories we create have zeroed group and other flags
> regardless of the umask? Or is this just a different default umask on
> FIPS? If it's just different umask the easiest solution would be
> changing the umask in the test setup.
Thanks! It's really just different umask, 0077 (where group umask is important).
Kind regards,
Petr
> And if it's regardless of umask settings shouldn't this rather be:
> if (tst_fips_enabled() && !strcmp(tc->name, "/"))
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-01-10 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 13:23 [LTP] [PATCH 1/2] chdir01.c: Fix on enabled FIPS Petr Vorel
2021-12-13 13:23 ` [LTP] [PATCH 2/2] chdir01.c: Minor cleanup Petr Vorel
2022-01-10 15:19 ` Cyril Hrubis
2022-01-12 15:29 ` Petr Vorel
2022-01-10 15:18 ` [LTP] [PATCH 1/2] chdir01.c: Fix on enabled FIPS Cyril Hrubis
2022-01-10 17:27 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdxsdDctFxoWI4E5@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox