From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AA3EC433EF for ; Tue, 25 Jan 2022 11:52:53 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id CA6A13C928D for ; Tue, 25 Jan 2022 12:52:50 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 517923C928A for ; Tue, 25 Jan 2022 12:52:42 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id CEECF2009BB for ; Tue, 25 Jan 2022 12:52:41 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1DB291F380; Tue, 25 Jan 2022 11:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1643111561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QyhrO0DxFmSjFC/pmghM0FylCbCl6U2Qs6V076nqAao=; b=cmi6KA9ttpeOrgMwUzyKgoMqoTvUeurYjD19xdxjUhfzCl2Z83/zBkVtbmJpk7Wlmy1qP/ dBpDLQ1UvvSQKryXaS7pspVqJY4iyDjn+yXiChFSNxrnwtobn1B3/SQUhUaWXO7MPzBRTf lLEkjq6l0I1Ceq+e/DWxYmV892woo30= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1643111561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QyhrO0DxFmSjFC/pmghM0FylCbCl6U2Qs6V076nqAao=; b=Fo6Lj7HK0HO/OxWcveb27+Qr4Z52zetT3cDUztuIWGl9RfCEY+amnuS2Ms6w49fQwQVjSP ZQccB/FSXEEsjNBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 09F3B13DD1; Tue, 25 Jan 2022 11:52:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id spaLAYnk72HIGQAAMHmgww (envelope-from ); Tue, 25 Jan 2022 11:52:41 +0000 Date: Tue, 25 Jan 2022 12:54:29 +0100 From: Cyril Hrubis To: Richard Palethorpe Message-ID: References: <20220124173651.652-1-rpalethorpe@suse.com> <20220124173651.652-2-rpalethorpe@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 2/3] memcontrol02: Fix anon memory comparison X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > All memory is being compared with the size malloc'ed instead of just > > anon. > > > > Signed-off-by: Richard Palethorpe > > --- > > testcases/kernel/controllers/memcg/memcontrol02.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/testcases/kernel/controllers/memcg/memcontrol02.c b/testcases/kernel/controllers/memcg/memcontrol02.c > > index 411f5aea6..0d144cf2d 100644 > > --- a/testcases/kernel/controllers/memcg/memcontrol02.c > > +++ b/testcases/kernel/controllers/memcg/memcontrol02.c > > @@ -68,7 +68,7 @@ static void alloc_anon_50M_check(void) > > > > TST_EXP_EXPR(anon > 0, "(memory.stat.anon=%zd) > 0", anon); > > TST_EXP_EXPR(values_close(size, current, 3), > > - "(size=%zd) ~= (memory.stat.anon=%zd)", size, current); > > + "(size=%zd) ~= (memory.stat.anon=%zd)", size, anon); > > I do not get this, we compare size and current and then print anon? > > Should we just change the memory.stat.annon to memory.current instead? Or did you forget to change the current in the values_close() to annon as well? -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp