Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 1/2] tst_net.sh: Fix for disabled IPv6
Date: Mon, 24 Jan 2022 16:19:08 +0100	[thread overview]
Message-ID: <Ye7DbPmw1rq5wEhy@pevik> (raw)
In-Reply-To: <3611b369-89b8-c9bc-92b7-ea69f91fea13@suse.cz>

Hi Martin,

> tst_net_detect_ipv6() should probably run each check only once and cache
> the result. The function is called multiple times and tst_rhost_run()
> could be quite slow if the remote side is on a different physical machine.
You're right, ssh result needs to be cached. Thanks for a review!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-01-24 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 19:55 [LTP] [RFC PATCH 0/2] tst_net.sh: Fix for disabled IPv6 Petr Vorel
2022-01-19 19:55 ` [LTP] [RFC PATCH 1/2] " Petr Vorel
2022-01-24 14:19   ` Martin Doucha
2022-01-24 15:19     ` Petr Vorel [this message]
2022-01-19 19:55 ` [LTP] [RFC PATCH 2/2] broken_ip-nexthdr.sh: Check IPv6 support before forcing it Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye7DbPmw1rq5wEhy@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox