Re: [LTP] [PATCH 2/2] ustat0{1, 2}: Mark failure on Btrfs with known-fail tag

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> I'd prefer to have it in metadata html/pdf and in known-bug section.
> Thus I'd prefer:
> 
> 	.tags = (const struct tst_tag[]) {
> 		{"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see "
> 			"https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/"
> 		},
> 		{}
> 
> But while this is obviously ok for test output:
> 
> $ ./ustat01 -h
> ...
> Tags
> ----
> known-fail: ustat() is known to fail with EINVAL on Btrfs, see https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/
> 
> It gets parsed as new line:
> 
>   "ustat01": {
>    "tags": [
>      [
>       "known-fail",
>       "ustat() is known to fail with EINVAL on Btrfs, see ",
>       "https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/"
>      ]
>     ],
>    "fname": "testcases/kernel/syscalls/ustat/ustat01.c"
>   }
> 
> Unless you think it's useful to expect that tag values can have longer input and
> thus testinfo.pl should use all array items (except the first which is key),
> I'd go the easy way and put the link only to top level docparse section as you
> suggested.

I guess that the URL in the tag field is okay too. It makes the line
slightly longer, but at the same time it's more descriptive.

Anyway, can we please still consider this for the release?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp