From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Replace ltp_syscall with tst_syscall
Date: Thu, 20 Jan 2022 13:16:42 +0100 [thread overview]
Message-ID: <YelSqq5cG6JHFtyh@pevik> (raw)
In-Reply-To: <20220119152732.21189-1-andrea.cervesato@suse.de>
Hi Andrea,
> This modification is a first step into the old LTP API replacement and
> it has been completed with the following procedure:
> - removed ltp_syscall
> - replaced ltp_syscall with tst_syscall inside all tests
> - reshuffled headers inside tests to import tst_test.h before
> lapi/syscalls.h
So far we've done cleanup as whole test one by one.
Sure, why not solving one issue once.
Generally LGTM. I'd just appreciate if tst_test.h didn't have to be loaded at
first, but that's a minor issue.
also with these whole tree patches it's a problem that it either breaks some of
other patches (they will not be applicable) or this patch will not be applicable
(if not applied soon after the release).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-20 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 15:27 [LTP] [PATCH v1] Replace ltp_syscall with tst_syscall Andrea Cervesato
2022-01-20 12:16 ` Petr Vorel [this message]
2022-01-20 12:30 ` Andrea Cervesato via ltp
2022-01-20 12:41 ` Petr Vorel
2022-01-24 14:44 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YelSqq5cG6JHFtyh@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox