Re: [LTP] [PATCH v1] Replace ltp_syscall with tst_syscall

[Petr Vorel <pvorel@suse.cz>]

> Hi Petr!

> From my point of view, it would be nice if lapi code would only contain
> fallback code, without LTP API that requires tst_test.h or test.h. So it
> would be easy to split fallback code from "utilities" headers containing the
> most common functionalities to break the test if fallback functions are
> failing. This is the case of lapi/syscalls.h where tst_syscall is defined,
> but IMHO it should be defined out, somewhere in a "utils" header imported by
> tst_test.h or by tests which requires specific functionalities.

Well, we want to use tst_{brk,res}() in lapi :(. And these depend on counting
which mmap shared memory (see setup_ipc()). Thus things depend to each other.

Kind regards,
Petr

> This is possible only if all the tests are already in the new LTP API
> version tho, since old tests require to be refactored first.
Yep, that's the first thing to do, that's why we did not concentrated on
functional rewrite like this one, but on converting tests. Luckily lots of them
has been already rewritten.


Kind regards,
Petr

> Kind regards,

> Andrea

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp