From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FF68C433EF for ; Thu, 20 Jan 2022 15:29:43 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id F0AB93C96C8 for ; Thu, 20 Jan 2022 16:29:40 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 7FD403C91AD for ; Thu, 20 Jan 2022 16:29:31 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id D5E99200BBF for ; Thu, 20 Jan 2022 16:29:30 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F23921F394; Thu, 20 Jan 2022 15:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642692569; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sm61dhiQXYSsnsEh4ItoXHkrUHZ+ORfvB/tuCyMcf74=; b=yAIAD9jPxlkiSocjIaWqqNgu86i6EYzD3m0CS11Ns4SelUIma56vqOaOEKAG8CrkbNosWz 3QIXrmLMBh90Mdi3NTk1485AjYlt5P6i8hpVM31kwomN/tJRZ+LqRR+z+8NM57etM0HUaY 7jKzvRGqmgNCOO/7S2GfnQ22FahbwWk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642692569; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sm61dhiQXYSsnsEh4ItoXHkrUHZ+ORfvB/tuCyMcf74=; b=mQUFy4beHxH/eAOncnK8p5lX8zJem8YgRXHXPW6SOFDHUKcr+KnhfA57NGilhn/LbVd/ju vl1Z2CgM9FWJQ9DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE3DA13E8A; Thu, 20 Jan 2022 15:29:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wsMSNdl/6WE1PAAAMHmgww (envelope-from ); Thu, 20 Jan 2022 15:29:29 +0000 Date: Thu, 20 Jan 2022 16:31:13 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20220120150421.26639-1-andrea.cervesato@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220120150421.26639-1-andrea.cervesato@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1] Reduce needed memory by the dio_read test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > Signed-off-by: Andrea Cervesato > --- > runtest/ltp-aiodio.part4 | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/runtest/ltp-aiodio.part4 b/runtest/ltp-aiodio.part4 > index fc1e1d479..8c10f67fb 100644 > --- a/runtest/ltp-aiodio.part4 > +++ b/runtest/ltp-aiodio.part4 > @@ -62,7 +62,7 @@ DIT002 dio_truncate > #Running read_checkzero > #gread_checkzero > #Running dio_read > -DOR000 dio_read -n 1 -i 100 > -DOR001 dio_read -n 10 -i 30 > -DOR002 dio_read -n 20 -i 15 > -DOR003 dio_read -n 100 -i 4 > +DOR000 dio_read -n 1 -i 100 -r 512k -w 512k -s 5M > +DOR001 dio_read -n 10 -i 30 -r 512k -w 512k -s 5M > +DOR002 dio_read -n 20 -i 15 -r 512k -w 512k -s 5M > +DOR003 dio_read -n 100 -i 4 -r 512k -w 512k -s 5M Limiting the child buffer to 512k makes sense, at least in the cases where n > 1 as by default the child allocates 32MB buffer, with 100 children that makes up to ~3GB. Also this really should have been in the patch description, which should really describe why the changes have been done. But I'm not sure about the -s 5M part, the file size was always 128MB before and reducing it to 5M sounds like too much. On my machine that reduces the testing time from about one minute to a few seconds, that sounds like change that is too radical without further explanation. If we want to run the test with smaller file size I would go for 64M, that reduces the runtime to half without reducing the changes for triggering a bug too much. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp