From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Reduce needed memory by the dio_read test
Date: Fri, 21 Jan 2022 10:27:58 +0100 [thread overview]
Message-ID: <Yep8ntzBsWApxU8c@yuki> (raw)
In-Reply-To: <Yep6u4N+phjB32Xd@pevik>
Hi!
> No, this is wrong. Also the issue can be just a timeout.
> ADSP074 (uses -n 512) runs framework ~3.5 min, ADSP075 (uses -n 1000) gets killed
> by LTP timeout. Do we want to increase tst_test.timeout for test?
>
> Am I correct that we cannot increase based on particular input (for particular
> getopt value) as we cannot later update results.timeout during run?
There actually is tst_set_timeout() however in this case I wouldn't
bother because the test runtime largerly depends on the actuall speed of
the disk it is writing to and other parameters of the test such as block
size and the actual formula would be quite complex.
Also I do plan to fix this properly by V2 of the runtime patchset once
the release is finished, so I would go for minimal fix just before the
release which would be setting tst_test.timeout to sufficiently large
value.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-21 9:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 15:04 [LTP] [PATCH v1] Reduce needed memory by the dio_read test Andrea Cervesato
2022-01-20 15:07 ` Martin Doucha
2022-01-20 15:31 ` Cyril Hrubis
2022-01-21 8:56 ` Petr Vorel
2022-01-21 9:19 ` Petr Vorel
2022-01-21 9:27 ` Cyril Hrubis [this message]
2022-01-21 9:30 ` Cyril Hrubis
2022-01-21 10:23 ` Petr Vorel
2022-01-21 9:02 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yep8ntzBsWApxU8c@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox