From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
Date: Fri, 21 Jan 2022 11:36:26 +0100 [thread overview]
Message-ID: <YeqMqtK0BziwRuNm@yuki> (raw)
In-Reply-To: <07fa4901-8384-bfb3-fcc8-eb408b120f5c@suse.com>
Hi!
> SAFE_MUNMAP should be called always, even if *run_child == 0 (which happens if run() completed successfully).
This is actually if (run_child) not if (*run_child) and it fixes the
case where the test is skipped even before the run_child has been
mmaped.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-21 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 10:06 [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs Petr Vorel
2022-01-21 10:16 ` Petr Vorel
2022-01-21 10:37 ` Cyril Hrubis
2022-01-21 11:12 ` Andrea Cervesato via ltp
2022-01-21 10:32 ` Andrea Cervesato via ltp
2022-01-21 10:36 ` Cyril Hrubis [this message]
2022-01-21 10:38 ` Petr Vorel
2022-01-21 10:42 ` Cyril Hrubis
2022-01-21 10:43 ` Petr Vorel
2022-01-21 11:22 ` Andrea Cervesato via ltp
2022-01-21 11:48 ` Martin Doucha
2022-01-21 11:56 ` Cyril Hrubis
2022-01-21 13:26 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeqMqtK0BziwRuNm@yuki \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox