* [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
@ 2022-01-21 10:06 Petr Vorel
2022-01-21 10:16 ` Petr Vorel
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Petr Vorel @ 2022-01-21 10:06 UTC (permalink / raw)
To: ltp
tmpfs does not support it.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/kernel/io/ltp-aiodio/aiodio_append.c | 10 ++++++++--
testcases/kernel/io/ltp-aiodio/dio_append.c | 4 ++++
testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++++
testcases/kernel/io/ltp-aiodio/dio_sparse.c | 10 ++++++++--
testcases/kernel/io/ltp-aiodio/dio_truncate.c | 10 ++++++++--
5 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/testcases/kernel/io/ltp-aiodio/aiodio_append.c b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
index cb04b04a57..46cc74ee4e 100644
--- a/testcases/kernel/io/ltp-aiodio/aiodio_append.c
+++ b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
@@ -131,8 +131,10 @@ static void setup(void)
static void cleanup(void)
{
- *run_child = 0;
- SAFE_MUNMAP(run_child, sizeof(int));
+ if (run_child) {
+ *run_child = 0;
+ SAFE_MUNMAP(run_child, sizeof(int));
+ }
}
static void run(void)
@@ -177,6 +179,10 @@ static struct tst_test test = {
{"b:", &str_numaio, "Number of async IO blocks (default 16)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
#else
TST_TEST_TCONF("test requires libaio and its development packages");
diff --git a/testcases/kernel/io/ltp-aiodio/dio_append.c b/testcases/kernel/io/ltp-aiodio/dio_append.c
index 59fd710e70..c099793f6c 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_append.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
@@ -93,4 +93,8 @@ static struct tst_test test = {
{"c:", &str_appends, "Number of appends (default 1000)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
diff --git a/testcases/kernel/io/ltp-aiodio/dio_read.c b/testcases/kernel/io/ltp-aiodio/dio_read.c
index 2c2ec4bce0..67a28147fd 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_read.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_read.c
@@ -177,4 +177,8 @@ static struct tst_test test = {
{"s:", &str_filesize, "File size (default 128M)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
diff --git a/testcases/kernel/io/ltp-aiodio/dio_sparse.c b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
index 4ee2fbab18..39fc895d65 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_sparse.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
@@ -83,8 +83,10 @@ static void setup(void)
static void cleanup(void)
{
- *run_child = 0;
- SAFE_MUNMAP(run_child, sizeof(int));
+ if (run_child) {
+ *run_child = 0;
+ SAFE_MUNMAP(run_child, sizeof(int));
+ }
}
static void run(void)
@@ -129,4 +131,8 @@ static struct tst_test test = {
{"o:", &str_offset, "File offset (default 0)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
diff --git a/testcases/kernel/io/ltp-aiodio/dio_truncate.c b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
index 4bf11c9588..1fbf83de06 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_truncate.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
@@ -107,8 +107,10 @@ static void setup(void)
static void cleanup(void)
{
- *run_child = 0;
- SAFE_MUNMAP(run_child, sizeof(int));
+ if (run_child) {
+ *run_child = 0;
+ SAFE_MUNMAP(run_child, sizeof(int));
+ }
}
static void run(void)
@@ -163,4 +165,8 @@ static struct tst_test test = {
{"c:", &str_numwrites, "Number of append & truncate (default 100)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
--
2.34.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
2022-01-21 10:06 [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs Petr Vorel
@ 2022-01-21 10:16 ` Petr Vorel
2022-01-21 10:37 ` Cyril Hrubis
2022-01-21 11:12 ` Andrea Cervesato via ltp
2022-01-21 10:32 ` Andrea Cervesato via ltp
` (2 subsequent siblings)
3 siblings, 2 replies; 13+ messages in thread
From: Petr Vorel @ 2022-01-21 10:16 UTC (permalink / raw)
To: ltp
Hi all,
[Cc Li ]
> tmpfs does not support it.
Verifying with .all_filesystems, that only tmpfs is problematic
- tested on exfat, ntfs over FUSE, vfat (common linux filesystems obviously work)
That's why I avoided opening file with O_DIRECT in setup().
BTW I wonder what is the reason of duplicate entries in ltp-aiodio.part4?
i.e. dio_sparse, aiodio_append, dio_append, dio_truncate...
To create bigger load?
IMHO it'd make sense to run at least one test on .all_filesystems to check more
filesystems (dio_append seems to be quick), but I wouldn't done it when there
are duplicate entries.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
2022-01-21 10:16 ` Petr Vorel
@ 2022-01-21 10:37 ` Cyril Hrubis
2022-01-21 11:12 ` Andrea Cervesato via ltp
1 sibling, 0 replies; 13+ messages in thread
From: Cyril Hrubis @ 2022-01-21 10:37 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
> > tmpfs does not support it.
> Verifying with .all_filesystems, that only tmpfs is problematic
> - tested on exfat, ntfs over FUSE, vfat (common linux filesystems obviously work)
>
> That's why I avoided opening file with O_DIRECT in setup().
>
> BTW I wonder what is the reason of duplicate entries in ltp-aiodio.part4?
> i.e. dio_sparse, aiodio_append, dio_append, dio_truncate...
> To create bigger load?
>
> IMHO it'd make sense to run at least one test on .all_filesystems to check more
> filesystems (dio_append seems to be quick), but I wouldn't done it when there
> are duplicate entries.
Historicall mess I guess. We will clean that up in the next development
cycle.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
2022-01-21 10:16 ` Petr Vorel
2022-01-21 10:37 ` Cyril Hrubis
@ 2022-01-21 11:12 ` Andrea Cervesato via ltp
1 sibling, 0 replies; 13+ messages in thread
From: Andrea Cervesato via ltp @ 2022-01-21 11:12 UTC (permalink / raw)
To: Petr Vorel, ltp
[-- Attachment #1.1: Type: text/plain, Size: 981 bytes --]
Hi!
On 1/21/22 11:16, Petr Vorel wrote:
> Hi all,
>
> [Cc Li ]
>
>> tmpfs does not support it.
> Verifying with .all_filesystems, that only tmpfs is problematic
> - tested on exfat, ntfs over FUSE, vfat (common linux filesystems obviously work)
>
> That's why I avoided opening file with O_DIRECT in setup().
>
> BTW I wonder what is the reason of duplicate entries in ltp-aiodio.part4?
> i.e. dio_sparse, aiodio_append, dio_append, dio_truncate...
> To create bigger load?
To duplicate entries in ltp-aiodio.part4 doesn't make much sense and I
perfectly agree with you. Once the aiodio testing suite is finished, we
do need to change runtest file in order to have multiple scenarios with
different files/buffers size with a different number of sub-processes.
>
> IMHO it'd make sense to run at least one test on .all_filesystems to check more
> filesystems (dio_append seems to be quick), but I wouldn't done it when there
> are duplicate entries.
>
> Kind regards,
> Petr
>
[-- Attachment #1.2: Type: text/html, Size: 1599 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
2022-01-21 10:06 [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs Petr Vorel
2022-01-21 10:16 ` Petr Vorel
@ 2022-01-21 10:32 ` Andrea Cervesato via ltp
2022-01-21 10:36 ` Cyril Hrubis
2022-01-21 10:42 ` Cyril Hrubis
2022-01-21 11:48 ` Martin Doucha
3 siblings, 1 reply; 13+ messages in thread
From: Andrea Cervesato via ltp @ 2022-01-21 10:32 UTC (permalink / raw)
To: Petr Vorel, ltp
[-- Attachment #1.1: Type: text/plain, Size: 3870 bytes --]
Hi!
On 1/21/22 11:06, Petr Vorel wrote:
> tmpfs does not support it.
>
> Signed-off-by: Petr Vorel<pvorel@suse.cz>
> ---
> testcases/kernel/io/ltp-aiodio/aiodio_append.c | 10 ++++++++--
> testcases/kernel/io/ltp-aiodio/dio_append.c | 4 ++++
> testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++++
> testcases/kernel/io/ltp-aiodio/dio_sparse.c | 10 ++++++++--
> testcases/kernel/io/ltp-aiodio/dio_truncate.c | 10 ++++++++--
> 5 files changed, 32 insertions(+), 6 deletions(-)
>
> diff --git a/testcases/kernel/io/ltp-aiodio/aiodio_append.c b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
> index cb04b04a57..46cc74ee4e 100644
> --- a/testcases/kernel/io/ltp-aiodio/aiodio_append.c
> +++ b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
> @@ -131,8 +131,10 @@ static void setup(void)
>
> static void cleanup(void)
> {
> - *run_child = 0;
> - SAFE_MUNMAP(run_child, sizeof(int));
> + if (run_child) {
> + *run_child = 0;
> + SAFE_MUNMAP(run_child, sizeof(int));
SAFE_MUNMAP should be called always, even if *run_child == 0 (which happens if run() completed successfully).
> + }
> }
>
> static void run(void)
> @@ -177,6 +179,10 @@ static struct tst_test test = {
> {"b:", &str_numaio, "Number of async IO blocks (default 16)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
> #else
> TST_TEST_TCONF("test requires libaio and its development packages");
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_append.c b/testcases/kernel/io/ltp-aiodio/dio_append.c
> index 59fd710e70..c099793f6c 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_append.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
> @@ -93,4 +93,8 @@ static struct tst_test test = {
> {"c:", &str_appends, "Number of appends (default 1000)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_read.c b/testcases/kernel/io/ltp-aiodio/dio_read.c
> index 2c2ec4bce0..67a28147fd 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_read.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_read.c
> @@ -177,4 +177,8 @@ static struct tst_test test = {
> {"s:", &str_filesize, "File size (default 128M)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_sparse.c b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> index 4ee2fbab18..39fc895d65 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> @@ -83,8 +83,10 @@ static void setup(void)
>
> static void cleanup(void)
> {
> - *run_child = 0;
> - SAFE_MUNMAP(run_child, sizeof(int));
> + if (run_child) {
> + *run_child = 0;
> + SAFE_MUNMAP(run_child, sizeof(int));
> + }
> }
>
> static void run(void)
> @@ -129,4 +131,8 @@ static struct tst_test test = {
> {"o:", &str_offset, "File offset (default 0)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_truncate.c b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
> index 4bf11c9588..1fbf83de06 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_truncate.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
> @@ -107,8 +107,10 @@ static void setup(void)
>
> static void cleanup(void)
> {
> - *run_child = 0;
> - SAFE_MUNMAP(run_child, sizeof(int));
> + if (run_child) {
> + *run_child = 0;
> + SAFE_MUNMAP(run_child, sizeof(int));
> + }
> }
>
> static void run(void)
> @@ -163,4 +165,8 @@ static struct tst_test test = {
> {"c:", &str_numwrites, "Number of append & truncate (default 100)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
Kind regards,
Andrea
[-- Attachment #1.2: Type: text/html, Size: 4415 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
2022-01-21 10:06 [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs Petr Vorel
2022-01-21 10:16 ` Petr Vorel
2022-01-21 10:32 ` Andrea Cervesato via ltp
@ 2022-01-21 10:42 ` Cyril Hrubis
2022-01-21 10:43 ` Petr Vorel
2022-01-21 11:48 ` Martin Doucha
3 siblings, 1 reply; 13+ messages in thread
From: Cyril Hrubis @ 2022-01-21 10:42 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
Looks good to me, but since we are right before release I would be more
happier if this gets more than one review before it gets pushed.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
2022-01-21 10:42 ` Cyril Hrubis
@ 2022-01-21 10:43 ` Petr Vorel
2022-01-21 11:22 ` Andrea Cervesato via ltp
0 siblings, 1 reply; 13+ messages in thread
From: Petr Vorel @ 2022-01-21 10:43 UTC (permalink / raw)
To: Cyril Hrubis; +Cc: ltp
> Hi!
> Looks good to me, but since we are right before release I would be more
> happier if this gets more than one review before it gets pushed.
Definitely. Li, Andrea, Martin, could you please have a look?
Kind regards,
Petr
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
2022-01-21 10:43 ` Petr Vorel
@ 2022-01-21 11:22 ` Andrea Cervesato via ltp
0 siblings, 0 replies; 13+ messages in thread
From: Andrea Cervesato via ltp @ 2022-01-21 11:22 UTC (permalink / raw)
To: Petr Vorel, Cyril Hrubis; +Cc: ltp
It makes sense to avoid running tests using O_DIRECT on tmpfs, so patch
looks good to me.
On 1/21/22 11:43, Petr Vorel wrote:
>> Hi!
>> Looks good to me, but since we are right before release I would be more
>> happier if this gets more than one review before it gets pushed.
> Definitely. Li, Andrea, Martin, could you please have a look?
>
> Kind regards,
> Petr
>
>> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Kind regards,
Andrea
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs
2022-01-21 10:06 [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs Petr Vorel
` (2 preceding siblings ...)
2022-01-21 10:42 ` Cyril Hrubis
@ 2022-01-21 11:48 ` Martin Doucha
2022-01-21 11:56 ` Cyril Hrubis
2022-01-21 13:26 ` Petr Vorel
3 siblings, 2 replies; 13+ messages in thread
From: Martin Doucha @ 2022-01-21 11:48 UTC (permalink / raw)
To: Petr Vorel, ltp
Hi,
one tiny nit below, otherwise:
Reviewed-by: Martin Doucha <mdoucha@suse.cz>
On 21. 01. 22 11:06, Petr Vorel wrote:
> tmpfs does not support it.
What's "it"? ^
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/kernel/io/ltp-aiodio/aiodio_append.c | 10 ++++++++--
> testcases/kernel/io/ltp-aiodio/dio_append.c | 4 ++++
> testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++++
> testcases/kernel/io/ltp-aiodio/dio_sparse.c | 10 ++++++++--
> testcases/kernel/io/ltp-aiodio/dio_truncate.c | 10 ++++++++--
> 5 files changed, 32 insertions(+), 6 deletions(-)
>
> diff --git a/testcases/kernel/io/ltp-aiodio/aiodio_append.c b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-01-21 13:26 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-21 10:06 [LTP] [PATCH 1/1] aiodio: Skip tests on tmpfs Petr Vorel
2022-01-21 10:16 ` Petr Vorel
2022-01-21 10:37 ` Cyril Hrubis
2022-01-21 11:12 ` Andrea Cervesato via ltp
2022-01-21 10:32 ` Andrea Cervesato via ltp
2022-01-21 10:36 ` Cyril Hrubis
2022-01-21 10:38 ` Petr Vorel
2022-01-21 10:42 ` Cyril Hrubis
2022-01-21 10:43 ` Petr Vorel
2022-01-21 11:22 ` Andrea Cervesato via ltp
2022-01-21 11:48 ` Martin Doucha
2022-01-21 11:56 ` Cyril Hrubis
2022-01-21 13:26 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox