From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/4] lapi/sched.h: Add include <sched.h>
Date: Fri, 28 Jan 2022 14:33:46 +0100 [thread overview]
Message-ID: <YfPwulEymVgPHGGR@yuki> (raw)
In-Reply-To: <YfPwdgiq7MDM7E8a@yuki>
Hi!
> > We including headers in lapi headers instead of depending headers are
> > included in tests which use lapi headers.
>
> -ENOPARSE
>
> The patch itself looks good though.
>
> So maybe this should be something as:
>
> Include <sched.h> and "lapi/syscalls.h" in "lapi/sched.h" instead of the
> tests.
Also with the description fixed:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-28 13:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 14:40 [LTP] [PATCH v2 0/4] sched_{g,s}etattr01: Add missing policies Petr Vorel
2022-01-25 14:40 ` [LTP] [PATCH v2 1/4] lapi/sched.h: Add include <sched.h> Petr Vorel
2022-01-28 13:32 ` Cyril Hrubis
2022-01-28 13:33 ` Cyril Hrubis [this message]
2022-01-28 15:19 ` Petr Vorel
2022-01-25 14:40 ` [LTP] [PATCH v2 2/4] lapi: Move SCHED_DEADLINE definition from tests Petr Vorel
2022-01-25 15:07 ` Cyril Hrubis
2022-01-25 14:40 ` [LTP] [PATCH v2 3/4] sched_get_priority_min01: Add missing policies Petr Vorel
2022-01-25 14:46 ` Petr Vorel
2022-01-25 14:48 ` Petr Vorel
2022-01-25 15:15 ` Cyril Hrubis
2022-01-25 14:40 ` [LTP] [PATCH v2 4/4] sched_get_priority_max01: " Petr Vorel
2022-01-25 15:26 ` Cyril Hrubis
2022-01-25 15:05 ` [LTP] [PATCH v2 0/4] sched_{g,s}etattr01: " Cyril Hrubis
2022-01-25 15:55 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfPwulEymVgPHGGR@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox