Re: [LTP] [RFC PATCH 1/1] lib: Print in summary also tests not run at all

[Petr Vorel <pvorel@suse.cz>]

...
> > +++ b/lib/tst_test.c
> > @@ -811,6 +811,9 @@ static void do_exit(int ret)
> >   		fprintf(stderr, "broken   %d\n", results->broken);
> >   		fprintf(stderr, "skipped  %d\n", results->skipped);
> >   		fprintf(stderr, "warnings %d\n", results->warnings);
> > +		fprintf(stderr, "not run  %d\n", tst_test->tcnt -
> > +				results->passed - results->failed - results->broken -
> > +				results->skipped - results->warnings);
> IMO, these values are not necessary related. Refer to quotactl01.c( 
> tst_test->tcnt is less than results->passed)
Ah, correct. Also .test_all means tst_test->tcnt to be 0.
So my patch is utterly wrong.

> Also, if you want to add a new tag, you should define the situation for it.

What is my point: number of the defined tests does not mean they are all run.

Maybe printing number of the tests in the test (tst_test->tcnt or 1 when
tst_test->test_all)?

My point is to have an idea without looking into the code know how many tests
have been skipped on certain setup.

Kind regards,
Petr

> Best Regards
> Yang Xu

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp